From owner-svn-src-all@freebsd.org  Sun Oct 15 16:18:00 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CABA5E4614E;
 Sun, 15 Oct 2017 16:18:00 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8BF527EE56;
 Sun, 15 Oct 2017 16:18:00 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v9FGHxP3095916;
 Sun, 15 Oct 2017 16:17:59 GMT (envelope-from imp@FreeBSD.org)
Received: (from imp@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v9FGHxA2095914;
 Sun, 15 Oct 2017 16:17:59 GMT (envelope-from imp@FreeBSD.org)
Message-Id: <201710151617.v9FGHxA2095914@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org
 using -f
From: Warner Losh <imp@FreeBSD.org>
Date: Sun, 15 Oct 2017 16:17:59 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r324631 - head/sys/dev/nvme
X-SVN-Group: head
X-SVN-Commit-Author: imp
X-SVN-Commit-Paths: head/sys/dev/nvme
X-SVN-Commit-Revision: 324631
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Oct 2017 16:18:00 -0000

Author: imp
Date: Sun Oct 15 16:17:59 2017
New Revision: 324631
URL: https://svnweb.freebsd.org/changeset/base/324631

Log:
  Explicitly set reserved fields and 'fuse' to 0. This prevents us from
  acidentally sending bogus values in these fields, which some drives
  may reject with an error or worse (undefined behavior).
  
  This is especially needed for the ndadump routine which allocates the
  cmd from stack garbage....
  
  Sponsored by: Netflix

Modified:
  head/sys/dev/nvme/nvme.h

Modified: head/sys/dev/nvme/nvme.h
==============================================================================
--- head/sys/dev/nvme/nvme.h	Sun Oct 15 16:17:55 2017	(r324630)
+++ head/sys/dev/nvme/nvme.h	Sun Oct 15 16:17:59 2017	(r324631)
@@ -1082,7 +1082,11 @@ void	nvme_ns_rw_cmd(struct nvme_command *cmd, uint32_t
     uint64_t lba, uint32_t count)
 {
 	cmd->opc = rwcmd;
+	cmd->fuse = 0;
+	cmd->rsvd1 = 0;
 	cmd->nsid = nsid;
+	cmd->rsvd2 = 0;
+	cmd->rsvd3 = 0;
 	cmd->cdw10 = lba & 0xffffffffu;
 	cmd->cdw11 = lba >> 32;
 	cmd->cdw12 = count-1;