From owner-svn-src-head@freebsd.org Sun Feb 19 22:00:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6913BCE6B83; Sun, 19 Feb 2017 22:00:12 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 36B411B30; Sun, 19 Feb 2017 22:00:12 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v1JM0BF9013452; Sun, 19 Feb 2017 22:00:11 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v1JM0B3e013451; Sun, 19 Feb 2017 22:00:11 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201702192200.v1JM0B3e013451@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Ngie Cooper Date: Sun, 19 Feb 2017 22:00:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r313973 - head/tests/sys/geom/eli/pbkdf2 X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2017 22:00:12 -0000 Author: ngie Date: Sun Feb 19 22:00:11 2017 New Revision: 313973 URL: https://svnweb.freebsd.org/changeset/base/313973 Log: A forced commit to note other portion of the Makefile change accidentally committed in r313972 The code committed in r313962 implicitly relies on python 2.x to generate testvect.h . There are a handful of issues with this approach: - python is not an explicit build dependency for FreeBSD - python 2.x is deprecated and will be removed sometime in the future (potentially before 11.x's EOL), and the script does not function with python 3.5 (it uses deprecated idioms and incompatible function calls). - python(1) (by default) lives in /usr/local/bin (${LOCALBASE}/bin) and gentestvect.py is a dependency of testvect.h (prior to r313972) which means that if the mtime of the generator script was newer than the mtime of the test vector, it could cause a spurious build failure in build time or at install time. A better solution using C/C++ should be devised. Discussed with: allanjude MFC after: 2 weeks X-MFC with: r313962, r313972 Sponsored by: Dell EMC Isilon Modified: head/tests/sys/geom/eli/pbkdf2/Makefile Modified: head/tests/sys/geom/eli/pbkdf2/Makefile ============================================================================== --- head/tests/sys/geom/eli/pbkdf2/Makefile Sun Feb 19 21:19:44 2017 (r313972) +++ head/tests/sys/geom/eli/pbkdf2/Makefile Sun Feb 19 22:00:11 2017 (r313973) @@ -23,6 +23,6 @@ SRCS.pbkdf2= \ LIBADD.pbkdf2= crypto testvect.h: - python gentestvect.py > $@ + python gentestvect.py > ${.TARGET} .include