Date: Mon, 25 Jul 2011 13:58:07 -0500 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Andreas Tobler <andreast@FreeBSD.org> Cc: Attilio Rao <attilio@FreeBSD.org>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, FreeBSD Release Engineering Team <re@FreeBSD.org> Subject: Re: svn commit: r224216 - in head/sys: ia64/ia64 mips/mips powerpc/aim sparc64/sparc64 Message-ID: <4E2DBCBF.2030402@freebsd.org> In-Reply-To: <4E2DB8AC.3000703@FreeBSD.org> References: <201107191241.p6JCfvqw072816@svn.freebsd.org> <4E2C9012.602@freebsd.org> <4E2DB8AC.3000703@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/25/11 13:40, Andreas Tobler wrote: > On 24.07.11 23:35, Nathan Whitehorn wrote: >> On 07/19/11 07:41, Attilio Rao wrote: >>> Author: attilio >>> Date: Tue Jul 19 12:41:57 2011 >>> New Revision: 224216 >>> URL: http://svn.freebsd.org/changeset/base/224216 >>> >>> Log: >>> On 64 bit architectures size_t is 8 bytes, thus it should use an 8 bytes >>> storage. >>> Fix the sintrcnt/sintrnames specification. >>> >>> No MFC is previewed for this patch. >>> >> >> These also need to be .long on 32-bit PowerPC, otherwise this change >> triggers kernel panics and faults in sysctl. Please change it as quickly >> as possible. > > Like the below? > > I'll test and I could commit if ok. (Build and approval) > > Gruss, > Andreas > > Index: locore32.S > =================================================================== > --- locore32.S (revision 224326) > +++ locore32.S (working copy) > @@ -91,13 +91,13 @@ > GLOBAL(intrnames) > .space INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 > GLOBAL(sintrnames) > - .word INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 > + .long INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 > > .align 4 > GLOBAL(intrcnt) > .space INTRCNT_COUNT * 4 * 2 > GLOBAL(sintrcnt) > - .word INTRCNT_COUNT * 4 * 2 > + .long INTRCNT_COUNT * 4 * 2 > > .text > .globl btext Exactly like that. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E2DBCBF.2030402>