From owner-svn-src-head@freebsd.org Wed May 3 12:41:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BDBAD5B044; Wed, 3 May 2017 12:41:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C52E8C49; Wed, 3 May 2017 12:41:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v43CfHCU000303 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 3 May 2017 15:41:17 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v43CfHCU000303 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v43CfGdt000302; Wed, 3 May 2017 15:41:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 3 May 2017 15:41:16 +0300 From: Konstantin Belousov To: Bruce Evans Cc: emaste@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317681 - head/share/man/man7 Message-ID: <20170503124116.GR1622@kib.kiev.ua> References: <201705021452.v42EqZSB010115@repo.freebsd.org> <20170503013818.F2099@besplex.bde.org> <20170502174455.GJ1622@kib.kiev.ua> <20170503035045.Q2870@besplex.bde.org> <20170502194525.GL1622@kib.kiev.ua> <20170503153946.M910@besplex.bde.org> <20170503100632.GQ1622@kib.kiev.ua> <20170503203449.E1771@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170503203449.E1771@besplex.bde.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 12:41:28 -0000 On Wed, May 03, 2017 at 08:57:10PM +1000, Bruce Evans wrote: > On Wed, 3 May 2017, Konstantin Belousov wrote: > > > On Wed, May 03, 2017 at 04:19:08PM +1000, Bruce Evans wrote: > >> On Tue, 2 May 2017, Konstantin Belousov wrote: > >>> +.Pp > >>> +.Sy time_t > >>> +is always signed, it is 64-bits everywere except on i386 and 32-bit powerpc. > >> > >> Change "is always" to "On all supported arches" as elsewhere. > >> > >> "everywhere" > >> > >> "everywhere" is redundant. > > Ok. > > > >> > >> The whole second clause is redundant. Remove it. Leave it to the reader > >> to notice that the table has more 8's than 4's, and where the 4's are. > > No, this is one of the important reasons why this narrative text added > > at all. > > Why? You just added time_t to the table. It needs to be described twice > less than most types. > > Now I don't like the indirection long -> sizeof(void *) in the first table. > This is the only place where the size is not given as a literal. There > used to be space in the second table to give the size of long explicitly. > Now the space is used for time_t. It doesn't belong in the same table, > since it is not a basic type. > > Also, intptr_t and intmax_t are not in the tables. > > > diff --git a/share/man/man7/arch.7 b/share/man/man7/arch.7 > > index 47a72a1986d..62781430329 100644 > > --- a/share/man/man7/arch.7 > > +++ b/share/man/man7/arch.7 > > @@ -36,8 +36,9 @@ > > Differences between CPU architectures and platforms supported by > > .Fx . > > .Pp > > +If not explicitly mentioned, sizes are in bytes. > > The first clause is redundant. There are no explicit mentions of non-byte > sizes. > > > .Ss Type sizes > > -On all supported architectures, > > +On all supported architectures: > > I see a further problem with this clause. It is separated from the table > that it applies to, by both indentation and a blank line, so it appears > to apply to the second table also. > > Later sections don't have a blank line where they reasonably could. They > start with a section header, then no blank line between that and the single > table in the section. Th discussion is now reduced to the opinions. Do you have any further objections due to factual mistakes or language errors in the proposed patch ? If not, I will commit it as is.