From owner-freebsd-current Sat Apr 5 04:14:16 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA03993 for current-outgoing; Sat, 5 Apr 1997 04:14:16 -0800 (PST) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id EAA03986 for ; Sat, 5 Apr 1997 04:14:09 -0800 (PST) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.8.5/8.8.5) with SMTP id NAA21842; Sat, 5 Apr 1997 13:14:18 +0100 (BST) Date: Sat, 5 Apr 1997 13:14:18 +0100 (BST) From: Doug Rabson To: Peter Dufault cc: current@freebsd.org Subject: Re: Breaking the lkm DISPATCH macro In-Reply-To: <199704051006.FAA08421@hda.hda.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sat, 5 Apr 1997, Peter Dufault wrote: > Heads up: > > I'm about to break LKM's DISPATCH macro by passing in the name > argument. LKM's are broken in -current for MOD_DEV, and in fixing > them I want to eliminate the static _module structure by prepending > the name. > > This can't be done compatably (without cruft like feature test macros) > since DISPATCH uses _module directly and the new MOD_DECL functions > will prepend the name. > > The interface change will require changing DISPATCH to > MOD_DISPATCH (gratuitous for consistency with the other macros) > and passing the name in. I'm keeping a DISPATCH macro there to > generate an error that leads back to the header to see what changed. > > I've fixed the code in the tree but user LKMs in -current will break. > They're already broken in -current versus non -current since the name > argument has changed from a string to an identifier so I think that > is a minor issue. Does this mean that my OSS module will stop working? Sigh.. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891