From owner-svn-ports-head@freebsd.org Tue Sep 27 21:14:27 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52D18BEA063; Tue, 27 Sep 2016 21:14:27 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E2D8131A; Tue, 27 Sep 2016 21:14:26 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 0D04EBDD36; Tue, 27 Sep 2016 23:14:24 +0200 (CEST) Received: from atuin.in.mat.cc (48.196.7.109.rev.sfr.net [109.7.196.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id CAC0FBDD22; Tue, 27 Sep 2016 23:14:23 +0200 (CEST) Subject: Re: svn commit: r422826 - head/security/libsodium To: marino@freebsd.org, Vsevolod Stakhov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201609271943.u8RJhXe0061946@repo.freebsd.org> <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: Date: Tue, 27 Sep 2016 23:14:22 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OQUDS9nLEBMBXT1D1vhcqaKKK3QwOGeqJ" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 21:14:27 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OQUDS9nLEBMBXT1D1vhcqaKKK3QwOGeqJ Content-Type: multipart/mixed; boundary="e9cwPVVEpgqdq9wFWhrrORv0kbvfqQ3HM"; protected-headers="v1" From: Mathieu Arnold To: marino@freebsd.org, Vsevolod Stakhov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r422826 - head/security/libsodium References: <201609271943.u8RJhXe0061946@repo.freebsd.org> <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> In-Reply-To: <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> --e9cwPVVEpgqdq9wFWhrrORv0kbvfqQ3HM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 27/09/2016 =C3=A0 21:51, John Marino a =C3=A9crit : > On 9/27/2016 14:43, Vsevolod Stakhov wrote: >> Author: vsevolod >> Date: Tue Sep 27 19:43:32 2016 >> New Revision: 422826 >> URL: https://svnweb.freebsd.org/changeset/ports/422826 >> >> Log: >> - Update to 1.0.11 >> >> No bump for dependent port is required as this version has no API >> changes >> >> >> Modified: head/security/libsodium/pkg-plist >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> >> --- head/security/libsodium/pkg-plist Tue Sep 27 18:25:34 2016 =20 >> (r422825) >> +++ head/security/libsodium/pkg-plist Tue Sep 27 19:43:32 2016 =20 >> (r422826) >> @@ -58,7 +58,7 @@ include/sodium/version.h >> lib/libsodium.a >> lib/libsodium.so >> lib/libsodium.so.18 >> -lib/libsodium.so.18.1.0 >> +lib/libsodium.so.18.1.1 >> libdata/pkgconfig/libsodium.pc >> %%PORTDOCS%%%%DOCSDIR%%/AUTHORS >> %%PORTDOCS%%%%DOCSDIR%%/README.markdown >> > > First, I don't think the "no API change" means a bump is not mandatory.= > Secondly, the SO name of the library changed!!! You have to bump it, > there's no question here. > > It's 1000x better to bump unnecessarily than to skip a bump that is > required. No it did not. $ readelf -d `make -V STAGEDIR`/usr/local/lib/libsodium.so|grep soname 0x000000000000000e SONAME Library soname: [libsodium.so.18= ] The file name changed, but software will try to find libsodium.so.18, and that will still work. --=20 Mathieu Arnold --e9cwPVVEpgqdq9wFWhrrORv0kbvfqQ3HM-- --OQUDS9nLEBMBXT1D1vhcqaKKK3QwOGeqJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX6uEvXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IzDUP/3E6gwyocSXR6er6h5r00uRp rZFc4LTHA6fbX9IUX77AjYkZrj3c4kre/xTS6JFD6/nu4Pn6ZFk17BtO5WDpTV3I cIbyYCQumNacvtjtoiwF1vQMeiMjFEsq4/whD5aqAVnDrQrTZsNex4zTZgkVjaLh t+BLLpJiblpHy0SeVLsOoP5kOuXWjnrErU8MKiRFqRpvzsl87jxTktwqfueQsdyz qaP5fZ06ChLYuecw9gU39ZoBfnWBYWM9sA1n2+nTDJQ5kJg2NMVZxgDkLiHs3GzT TLWO0u8QBdvOm8l/nwXphMPqtGhq5DkMZFNH9LT/JTO6sqTcCf6T6xvbv7qOX6qo KuAdsJEO2SsslCjchvUR6rjEn4eh+PtMk/0rC1T6gPpUWW1SH4SlkfWyOYUShTcv 7gRVdMZrsI8V5JIVaw9SJWrdNWMpwLKYSYSpeEkPi0LAXfr1LqFIysYXH9H1apFt k+0cYjuSOebM2FqnQcWtj6XPJxlTsvdZW6GEcjZMjLiBHW44CqoIbBVy5JnhgiJC FlonweaEyG9tgBS+/I48uvokuJr2AIJOcf+uVUbbsPME4zcJuDRoWv+mSnU+8gjf dI1t67/HwiMrvyzfgpNtlYz2XXvTVprqoDfEdeAqm0HqHFEFFSjKrM5+RoGWXryb Wb6YhHOlKYCgmHtx2u3R =83pe -----END PGP SIGNATURE----- --OQUDS9nLEBMBXT1D1vhcqaKKK3QwOGeqJ--