Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Apr 2023 15:55:00 +0200
From:      Mathieu Arnold <mat@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Muhammad Moinur Rahman <bofh@freebsd.org>,  ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS
Message-ID:  <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3>
In-Reply-To: <ZDa1j/k5bMGxfDH0@FreeBSD.org>
References:  <202304120539.33C5dOJA014331@gitrepo.freebsd.org> <ZDa1j/k5bMGxfDH0@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--o7oaqo5ii6fxysmo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 12, 2023 at 01:43:43PM +0000, Alexey Dokuchaev wrote:
> On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote:
> > commit c89b6f2799891129e89d1b4fedf8e25865241060
> >=20
> >   lang/php8[12]: Fix build on aarch64 with ZTS
> >=20
> >   - Refresh patches
>=20
> What good did it bring other than cloaking the actual fix with tons
> of needless, unrelated changes?  You've poured a glass of honey into
> a bucket of tar. :(

Because that is something you have to do everytime a port is updated,
refresh the patches so that the line offsets are correct wrt current
sources, to make sure patch(1) can just apply the patches and not resort
to guesswork.

--=20
Mathieu Arnold

--o7oaqo5ii6fxysmo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQ2uDRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb5iIgwAta0PRRU8uWoNujbpDceGVjV0D7XWq5JGd0AQ0dlTsn5PO+/6YaHHPAHU
xokU8fnphELd+FVhwRE5CzA7H9QAPWmZVo14Y4h0Ub1cu3giMNaLVv3gA0O6MT52
KzdfEJM/J4FpMjb4H/zirirp0sI6/rVxbKUMlXfmUMuvpn389+wBO+er8PKIKTda
GOkJnvOKTTC4iBAmszLsPoy3/l5D2Znym51DbqFpM/D+i02gW0vfog6+82CxN0Lh
MO4nN1RLeuiWHmtGWQIIFTNAPZMlVkH2q8PerOUU5NLibCJ7+AtE7H0rIeUurJ6Y
Zc33/a996yAS/SBfAn+dg9hh5fpxxu1AUlYf67xpMwp8MT7Ryhx1YQ6OnE+5iAIq
XU4sysRg+6OVzcmYHUXPC9R14667AaYm33gf0noYm2aWWShKuyAlwWnYsaNy5/eA
fveT1ZZVTiAUeL7pKESlMlixWkY9VfpCGqqXVi9xl0oiT9OWhMRr6VcRwy+idAZr
UbeN8as3
=8rsO
-----END PGP SIGNATURE-----

--o7oaqo5ii6fxysmo--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc>