From owner-svn-src-head@FreeBSD.ORG Thu May 7 19:21:20 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FC671065673; Thu, 7 May 2009 19:21:20 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from contrabass.post.ru (contrabass.post.ru [85.21.78.5]) by mx1.freebsd.org (Postfix) with ESMTP id A8D6D8FC22; Thu, 7 May 2009 19:21:19 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from corbina.ru (mail.post.ru [195.14.50.16]) by contrabass.post.ru (Postfix) with ESMTP id 6792E99830; Thu, 7 May 2009 23:21:18 +0400 (MSD) X-Virus-Scanned: by cgpav Uf39PSi9pFi9oFi9 Received: from [10.208.17.3] (HELO dchagin.static.corbina.ru) by corbina.ru (CommuniGate Pro SMTP 5.1.14) with ESMTPS id 1777728691; Thu, 07 May 2009 23:21:18 +0400 Received: from dchagin.static.corbina.ru (localhost.chd.net [127.0.0.1]) by dchagin.static.corbina.ru (8.14.3/8.14.3) with ESMTP id n47JLHNM038758; Thu, 7 May 2009 23:21:17 +0400 (MSD) (envelope-from dchagin@dchagin.static.corbina.ru) Received: (from dchagin@localhost) by dchagin.static.corbina.ru (8.14.3/8.14.3/Submit) id n47JLC9f038757; Thu, 7 May 2009 23:21:12 +0400 (MSD) (envelope-from dchagin) Date: Thu, 7 May 2009 23:21:12 +0400 From: Chagin Dmitry To: Jamie Gritton Message-ID: <20090507192112.GA37183@dchagin.static.corbina.ru> References: <200905071836.n47IalFi064565@svn.freebsd.org> <20090507185731.GA31336@dchagin.static.corbina.ru> <4A0333E4.1070101@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline In-Reply-To: <4A0333E4.1070101@FreeBSD.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191896 - in head/sys: amd64/linux32 compat/linux i386/linux kern sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2009 19:21:20 -0000 --J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 07, 2009 at 01:17:56PM -0600, Jamie Gritton wrote: > Chagin Dmitry wrote: > > On Thu, May 07, 2009 at 06:36:47PM +0000, Jamie Gritton wrote: > >> Author: jamie > >> Date: Thu May 7 18:36:47 2009 > >> New Revision: 191896 > >> URL: http://svn.freebsd.org/changeset/base/191896 > >> > >> Log: > >> Move the per-prison Linux MIB from a private one-off pointer to the = new > >> OSD-based jail extensions. This allows the Linux MIB to accessed via > >> jail_set and jail_get, and serves as a demonstration of adding jail = support > >> to a module. > >> =20 > >> Reviewed by: dchagin, kib > >> Approved by: bz (mentor) > >> > >=20 > >=20 > > whoops > >=20 > > -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fforma= t-extensions -c /work/pub/head/sys/modules/linux/../../compat/linux/linux_m= ib.c > > cc1: warnings being treated as errors > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c: In fun= ction 'linux_prison_check': > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:232: wa= rning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:243: wa= rning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c: In fun= ction 'linux_prison_set': > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:272: wa= rning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:277: wa= rning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > *** Error code 1 > >=20 > > Stop in /work/pub/head/sys/modules/linux. > > *** Error code 1 >=20 > Never saw that - must be something funny about compiling a Current > kernel on a Release 7 box. >=20 > - Jamie size_t !=3D int on some arch. # cat __tmp.patch diff --git a/sys/compat/linux/linux_mib.c b/sys/compat/linux/linux_mib.c index fd17773..c5734a0 100644 --- a/sys/compat/linux/linux_mib.c +++ b/sys/compat/linux/linux_mib.c @@ -223,7 +223,7 @@ linux_prison_check(void *obj __unused, void *data) { struct vfsoptlist *opts =3D data; char *osname, *osrelease; - size_t len; + int len; int error, oss_version; /* Check that the parameters are correct. */ @@ -263,7 +263,7 @@ linux_prison_set(void *obj, void *data) struct prison *pr =3D obj; struct vfsoptlist *opts =3D data; char *osname, *osrelease; - size_t len; + int len; int error, gotversion, nolinux, oss_version, yeslinux; /* Set the parameters, which should be correct. */ --=20 Have fun! chd --J/dobhs11T7y2rNN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEARECAAYFAkoDNKcACgkQ0t2Tb3OO/O3u0QCcD3Y0vPgOS3e6i1LKoctwqDTw VfwAnix41v6v+raihuIY7u4zyql7a7Ru =N0OA -----END PGP SIGNATURE----- --J/dobhs11T7y2rNN--