From nobody Mon Jul 7 13:42:02 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbQQX51Srz61lfs for ; Mon, 07 Jul 2025 13:42:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbQQX2cQnz3Gd6 for ; Mon, 07 Jul 2025 13:42:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6facc3b9559so53118936d6.0 for ; Mon, 07 Jul 2025 06:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751895726; x=1752500526; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=LHRiBK5vutaL4aE+MkowiDqhDu1S2XvEAHC5A3E+4CQ=; b=RXyaOXuNZOLzf8DqO2itovUMiDIKubiSJ1u0IwSkhEsTNX4qkbUJS6qZ34klOPedYt iVdPtjgmhUcJ3TVGY1EwUafRuZ26T2KYuAidEMXcfgUFfmTcQXsaISGYGF+to94QfWUl JhFt/dTI2ov+o/gYFU6diwuZrXpzYHSfCa+kizadgnaS3lQGhfIqa4VK78xMt/tHbQkY eFJpU0JaeshPifoDGDdh4gFC06F+5+X5fenLN5JTZzWt5vUorsnnl5NZHhuPwM113Q/T UiFoaO6X2GfoMT9gZiWTlvHAfWL/Y/JaAhzojqSe+msNE4B63WcZAN7FzBgNUSoUS23W fGoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751895726; x=1752500526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHRiBK5vutaL4aE+MkowiDqhDu1S2XvEAHC5A3E+4CQ=; b=V4qlvf2eFbN1VQ5yHM/EH2Opm24wXEukb7+BrApmC52XI3oSbqwI5Zh6g3VTGCE2zc bLi6rkoGbwfyGGNUTdUg5r941Bhdkqishh7qGT+eqmP6pWhXwY38KPrPDc+HPi57FpO+ rQ40tekxl5z6CzisoR7/ayiHlYep8Fk55UErcG9obtr/mU2Hr6G7iLElaDhJUU6F+d34 +RpCoPHEDp2ftXe0PuKrpl6x7iWKfmlhvlfO9KCi4UyXjVycjw7qS52yzq1laaFyBPiN fjPDBTePtg1XmjbXNtOpqFfUQqHsLuRsdhLRApqAArhtiTMbBLUINuqB7lTuMwn1qLVD 4TFw== X-Forwarded-Encrypted: i=1; AJvYcCVh/OFfNuRG9xf5+zR5IF6WRZeOOymn6D1MRDlifPgFE+HrXB9S1wItM3Ch/dBNJPl1IiNFqpA8V2LA9F4lOv8=@freebsd.org X-Gm-Message-State: AOJu0Yy29d4I9ZlCtVsedpoufU3AFPkdkypIltUK5jOyl8OfpzpV9SBu 0ApsKCVtkac5P2HbpkkLCNeppIpBc29meFpsW/4PpdWjol1Py8pDZvHR X-Gm-Gg: ASbGncvCTeZnMsTUUIrgdQ7VclmgsTNdiM8HxORJ+qUB+jNT8zeS+uussbYOV5saCvy ohMBxayWSchsSFEbv9njem4QK8Jvi6bzgVEvLYk4CXnUQdsl/UxlgaRgAZtIqf47HJeJjBeHInV hRcO6egZBqtJfV8WigXOFkWwRRlNnGP1tLSVrL+FOIWHEDJHaqVHmvVEzK7HLwgxf7SWkyyXvCQ TYbvncnIKisSxi6JNLLJuI6F/y5pmZg5+bLT5iORodthke6BBu/jQnxussvsRGqWAosVtR7qKc5 mWUOg1W8njQzpaGVUmVj2mJgl/Plriu5nES0fsDakw3vlgtbDHpJ/B7XWixwa0hPMe4EKcMwUxU w X-Google-Smtp-Source: AGHT+IFVYI6BgENy96tahRhwFbgc3HZpup15WiOJdnJQZYdFsTziSWMBFYIrfszrLCf+pCZWP8n1rA== X-Received: by 2002:a05:6214:3c8b:b0:6fa:c81a:6234 with SMTP id 6a1803df08f44-702c6d01143mr261535876d6.10.1751895726306; Mon, 07 Jul 2025 06:42:06 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4ccd617sm58390486d6.44.2025.07.07.06.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 06:42:04 -0700 (PDT) Date: Mon, 7 Jul 2025 09:42:02 -0400 From: Mark Johnston To: Konstantin Belousov Cc: Oleg Nauman , FreeBSD Current , David Wolfskill Subject: Re: tail -f is broken in recent CURRENT ( afd5bc630930 Sunday Jul 6 ) Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4bbQQX2cQnz3Gd6 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Mon, Jul 07, 2025 at 03:51:00PM +0300, Konstantin Belousov wrote: > On Mon, Jul 07, 2025 at 03:36:12PM +0300, Oleg Nauman wrote: > > I noticed that > > tail -f /var/log/messages never receive updates if running with recent > > CURRENT ( afd5bc630930 Sunday Jul 6 ) > > > > 60092: read(3,"talled\nJul 6 16:59:54 mysystem pkg-static[86368]: > > gstreamer1-plugins-mpg123-1.26.2 deinstalled\nJul 6 16:59:57 mysytem > > pkg"...,32768) = 2666 (0xa6a) > > 60092: munmap(0x801403000,297578) = 0 (0x0) > > 60092: read(3,0x80182c600,32768) = 0 (0x0) > > 60092: kqueue() = 5 (0x5) > > 60092: fstatfs(3,{ > > fstypename=ufs,mntonname=/,mntfromname=/dev/gpt/FreeBSD-UFS,fsid=133a996124e0f956 > > }) = 0 (0x0) > > 60092: kevent(5,{ 3,EVFILT_READ,EV_ADD|EV_ENABLE|EV_CLEAR,0,0,0x0 > > },1,0x0,0,{ 0.000000000 }) = 0 (0x0) > > 60092: kevent(5,0x0,0,0x801814000,1,0x0) ERR#4 'Interrupted > > system call' <--- killed at this point by me > > 60095: select(7,{ 6 },0x0,0x0,0x0) ERR#4 'Interrupted system call' > > 60092: SIGNAL 2 (SIGINT) code=SI_KERNEL > > 60095: SIGNAL 2 (SIGINT) code=SI_KERNEL > > 60095: process killed, signal = 2 > > 60092: process killed, signal = 2 > > > > Likely something is wrong with kqueue and/or kevent > > Try this I tested this patch and can confirm that it fixes tail -f. Thank you. > diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h > index 3ed469bdce6d..2c6947103c94 100644 > --- a/sys/sys/vnode.h > +++ b/sys/sys/vnode.h > @@ -1032,7 +1032,7 @@ void vop_rename_fail(struct vop_rename_args *ap); > #define VOP_WRITE_POST(ap, ret) \ > noffset = (ap)->a_uio->uio_offset; \ > if (noffset > ooffset) { \ > - if (VN_KNLIST_EMPTY((ap)->a_vp)) { \ > + if (!VN_KNLIST_EMPTY((ap)->a_vp)) { \ > VFS_KNOTE_LOCKED((ap)->a_vp, NOTE_WRITE | \ > (noffset > osize ? NOTE_EXTEND : 0)); \ > } \ >