From owner-freebsd-virtualization@freebsd.org Thu Jul 25 14:27:56 2019 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 75C88A5DE2 for ; Thu, 25 Jul 2019 14:27:56 +0000 (UTC) (envelope-from sux2mfgj@gmail.com) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E20584E4B for ; Thu, 25 Jul 2019 14:27:55 +0000 (UTC) (envelope-from sux2mfgj@gmail.com) Received: by mail-oi1-x234.google.com with SMTP id l12so37822720oil.1 for ; Thu, 25 Jul 2019 07:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3oZ2iO3pG3gbCQNRSlZLlqzHW8e1FUXg+t0HkDa57EY=; b=U8GaPIelRwWAEJe7tryjM1ueY25VK1V/kqnto5j+JZEQcSMSjDLbrb3p5f3C8dhWGK A2ANbGdfFe6pzq136FhBjBmuAG+eB5ZuXnpTd9gbA+imdnU/svr2j3oKJhZmgcC1uO2c ZAQmXeArWN+cEiP5EmjS27ELcJaTofG3OeduQdCJrMd+MjFN8PN3rzidfoRm5OwyR1Kw yfZTj4XVUeel6NYkehPPGrVtB8geL5OgFMe2UeSpWqn5KQPW3hF1UQK2O38cM8Q4BucZ SXL/kluYJSKRj2BYCaZGEEmXPzBV78dq4TNsoRWmdvQJ334pot3rAy1bAWj6jYu42h8w FFOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3oZ2iO3pG3gbCQNRSlZLlqzHW8e1FUXg+t0HkDa57EY=; b=iEU9d2FLC5FWGAwpYwHvuCr1b0hIsFmUdSlLryPESkAuwS0x3UCunSUWPgwdMSi1xt PswJKQWnycM3Q2Ea3/FMJKPpRezmoaY5IT0+LrynmPRdBVLW30CF/RPOZoK/aYWdYAsq NlgDC1mwkiKIb0vHEL3+kZIN1iKyMJ1o3CvRpsXsuNcVFvPObf+m4sEKBiNoZniJMZ4d MZev7xYxn5gzNGxKYQYyuyZVYEa8m+blCGm+3cGYG9ob+HyuaEcl7Wa8Or7xhcOcm3M+ R6m/OhF/fQfeXTvWG5u490LldI3lwtwpffoZylBCJs9Wek1N0Iv50ON3BRHvS5QIpg1m DUDw== X-Gm-Message-State: APjAAAV149bWmpiVgcdiFklaLipJCxgXlbnvVJ/jYmc3VHB4iu1P8DD/ zP0UY8qmayekbBcp5vX81Sha8gpNMHx8+m9R6w5+UVN0CRU= X-Google-Smtp-Source: APXvYqz/rHuJo85DsK8hnL/iN1sVuXffz0ULzeF/wTmzAg2200wljUeh5EhpwZ+z/FmrvyG0G42WojRVREV4PN6w5AY= X-Received: by 2002:aca:4950:: with SMTP id w77mr45078484oia.28.1564064874450; Thu, 25 Jul 2019 07:27:54 -0700 (PDT) MIME-Version: 1.0 From: Shunsuke Mie Date: Thu, 25 Jul 2019 23:27:43 +0900 Message-ID: Subject: A mistake in a comment. To: freebsd-virtualization@freebsd.org X-Rspamd-Queue-Id: 9E20584E4B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=U8GaPIel; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of sux2mfgj@gmail.com designates 2607:f8b0:4864:20::234 as permitted sender) smtp.mailfrom=sux2mfgj@gmail.com X-Spamd-Result: default: False [-6.95 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[4.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.97)[ip: (-9.29), ipnet: 2607:f8b0::/32(-3.08), asn: 15169(-2.43), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 14:27:56 -0000 Hi, I'm reading a source code at a vmx entry to guest. I confused by a comment in here. https://github.com/freebsd/freebsd/blob/master/sys/amd64/vmm/intel/vmx_support.S#L138 . A prototype definition of the vmx_entry_guest is in vmx.h. ``` int vmx_enter_guest(struct vmxctx *ctx, struct vmx *vmx, int launched); ``` So, is this a mistake? Thanks a lot. Shunsuke.