From owner-svn-src-head@FreeBSD.ORG  Tue Jun 12 21:46:03 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 913671065677;
	Tue, 12 Jun 2012 21:46:03 +0000 (UTC)
	(envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EAD98FC12;
	Tue, 12 Jun 2012 21:46:03 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
	by mail.dawidek.net (Postfix) with ESMTPSA id D702B36F;
	Tue, 12 Jun 2012 23:45:54 +0200 (CEST)
Date: Tue, 12 Jun 2012 23:44:00 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Message-ID: <20120612214400.GB1429@garage.freebsd.pl>
References: <201206112205.q5BM5QIv013266@svn.freebsd.org>
	<4FD6FD39.5090800@gmail.com> <20120612104749.GB20749@dft-labs.eu>
	<20120612114335.GA1372@garage.freebsd.pl>
	<20120612134950.GC20749@dft-labs.eu>
	<20120612160128.GA1429@garage.freebsd.pl>
	<20120612191828.GD20749@dft-labs.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD"
Content-Disposition: inline
In-Reply-To: <20120612191828.GD20749@dft-labs.eu>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, davidxu@FreeBSD.org
Subject: Re: svn commit: r236935 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2012 21:46:03 -0000


--EuxKj2iCbKjpUGkD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote:
> On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote:
> > Look good and you can just add 'In co-operation with: pjd'.
> > One minor thing is that fd_first_free() can return 'size' if there are
> > no free slots available. Could you include that in the comment as well?
> >=20
>=20
> http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free2.patch

Ok. Merge racct_set() call into one line, it now fits into 80 chars.
I have no more objections.

> > > fd_last_used has very same problem with comment as fd_first_free. This
> > > function is static and the only caller always passes 0 as low. Given
> > > that, how about the following:
> > > http://people.freebsd.org/~mjg/patches/fd_last_used-cleanup.patch
> >=20
> > Looks good too.
> >=20
>=20
> Updated in similar manner:
> http://people.freebsd.org/~mjg/patches/fd_last_used-cleanup2.patch

Ok.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--EuxKj2iCbKjpUGkD
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk/XuB8ACgkQForvXbEpPzRj0gCeK86N67zB4OQTukA3B9jX1Ih1
jDYAoPi14muxXnESwmNYqv3rjjSqUuTP
=gzMA
-----END PGP SIGNATURE-----

--EuxKj2iCbKjpUGkD--