From owner-cvs-src@FreeBSD.ORG Wed Apr 14 22:42:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68C6616A4D0 for ; Wed, 14 Apr 2004 22:42:27 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id E2B9143D5D for ; Wed, 14 Apr 2004 22:42:26 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 87305 invoked by uid 1000); 15 Apr 2004 05:42:29 -0000 Date: Wed, 14 Apr 2004 22:42:29 -0700 (PDT) From: Nate Lawson To: Kevin Oberman In-Reply-To: <20040414223714.091FE5D07@ptavv.es.net> Message-ID: <20040414223743.V87135@root.org> References: <20040414223714.091FE5D07@ptavv.es.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/dev/acpica hwsleep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2004 05:42:27 -0000 On Wed, 14 Apr 2004, Kevin Oberman wrote: > > njl 2004/04/14 09:52:19 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/contrib/dev/acpica hwsleep.c > > Log: > > Even though the patch has been submitted to the vendor, this file is off > > the vendor branch. Once more, with feeling! > > Boy, my timing suck of late. I just rebuilt my system to see if > unloading and loading the sound driver would fix my > sound-too-fast-after-resume problem. To my amazement, using the loadable > drivers I no longer had the problem. I did all sorts of testing to try > to figure out why this would make a difference. Then I decided to catch > up on cvs-all. > > Thanks, Nate. This fixes the sound problem on my T30. My only remaining > issue is turning off the @#$% back-light! (Not that there might not be > other issues I have not hit.) I can't see how this commit fixes your sound problem. Are you loading/unloading the device drivers (i.e. via /etc/rc.suspend,resume)? I could see that helping. Or is the problem fixed even without doing that? > First rule of troubleshooting...change only one variable at a time! > Learned that over 30 year ago, but still ignore it too often. It's often difficult to sit down and come up with the optimal test plan (for instance, binary search) and then stick to it. Usually after a while, the temptation is too great to just try what you think will fix it and then get lost in random, duplicative tests. I think this is related to the high we get from succeeding in record time due to intuition. Of course, we don't later remember the hours spent pursuing unfruitful intuitions and compare, we only remember the good ones. :-) -Nate