From owner-svn-src-head@freebsd.org Mon Jun 11 22:29:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F32A9100633D; Mon, 11 Jun 2018 22:29:37 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A13F181FD3; Mon, 11 Jun 2018 22:29:37 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7D5ED211E6; Mon, 11 Jun 2018 18:29:36 -0400 (EDT) Received: from web4 ([10.202.2.214]) by compute3.internal (MEProxy); Mon, 11 Jun 2018 18:29:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=H+YzUA OQ3T95ZgsG4W9HdFniwN/ttp392ReVqNJuWMI=; b=MQipGrKxppjCGuccWTnABo bVFW8NHc1ya/7ovG4UQcDoe19BD6V32v8H1lwFfim3fFM3QkErPLLeBqC4BtRpGa Q/WVzznMUU8NiYnynPZAShrqZH2mgbzm0cMVvTbTs4U1tHi4boBNhEq8v1H1Lqk9 n7hKrxJHXhNmcIivi16Ahzc4+nqSCENndDWXSdSAJvAW0KCXMo81Hg9H/IpumrXD MDyxVCPYVXG9THYoR3QCnHXbNDCfpNPZbLUEYXtBerrDuQnkAIP+FOCNdq/v/H84 W9kFMV+sHjt+gqYC8F1BqcmFRe3VddG6q0G+ZY7UiJc5k30yU5mNLtWX5jUNnK1A == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 2B2D1BA50D; Mon, 11 Jun 2018 18:29:36 -0400 (EDT) Message-Id: <1528756176.557409.1404618352.33DD9A15@webmail.messagingengine.com> From: Mark Felder To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-ca618090 In-Reply-To: <20180527060917.GA3179@FreeBSD.org> References: <201805251936.w4PJaQIf093393@repo.freebsd.org> <20180527060917.GA3179@FreeBSD.org> Subject: Re: svn commit: r334221 - head/etc Date: Mon, 11 Jun 2018 17:29:36 -0500 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 22:29:38 -0000 On Sun, May 27, 2018, at 01:09, Alexey Dokuchaev wrote: > On Fri, May 25, 2018 at 07:36:26PM +0000, Mark Felder wrote: > > New Revision: 334221 > > URL: https://svnweb.freebsd.org/changeset/base/334221 > > > > Log: > > rc.subr: Support loading environmental variables from a file > > > > + if [ -n "$_env_file" ] && [ -r "${_env_file}" ]; then > > Style bug: "$_env_file" vs. "${_env_file}". Also, isn't the -n check > redundant? The entire rc.subr file seems to be full of style inconsistencies. I'd take the time to fix it if there would be no objections. As per redundancy, it's copy+paste of what mat suggested. I suppose the -r will fail if the variable is not set, so it would indeed be redundant. I didn't think of it that way. > > > + set -a > > + . $_env_file > > Shouldn't it be quoted here as well (. "$_env_file")? > It wouldn't hurt Sorry about the late reply. I had a mistake in my sieve filters sending my mail to a wrong folder. -- Mark Felder ports-secteam & portmgr member feld@FreeBSD.org