From owner-freebsd-current Mon Oct 16 0:39:25 2000 Delivered-To: freebsd-current@freebsd.org Received: from storm.FreeBSD.org.uk (storm.freebsd.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id D03D437B502 for ; Mon, 16 Oct 2000 00:39:21 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.nat.Awfulhak.org [172.31.0.12]) by storm.FreeBSD.org.uk (8.11.0/8.11.0) with ESMTP id e9G7dFI17890; Mon, 16 Oct 2000 08:39:16 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.1/8.11.0) with ESMTP id e9G7dNY21088; Mon, 16 Oct 2000 00:39:24 -0700 (PDT) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200010160739.e9G7dNY21088@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Bruce Evans Cc: kargl@apl.washington.edu, freebsd-current@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: more endian.h breakage; patch included. In-Reply-To: Message from Bruce Evans of "Mon, 16 Oct 2000 11:44:20 +1100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 16 Oct 2000 00:39:23 -0700 From: Brian Somers Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Sun, 15 Oct 2000, Steven G. Kargl wrote: > > > There is another patch needed in libdialog. > > No patches are needed in applications; endian.h should be unbroken. In what way ? ntohl() & ntonl() were previously wrong to return u_long. They now return uint32_t (which requires sys/types.h). They *could* be changed to return u_int32_t, but this doesn't seem to be the best way forward. They *could* be changed to return unsigned, but I think this is worse than u_int32_t. I guess another alternative is to move the BYTE_ORDER into a different file and stop including endian.h from wait.h, but this seems wrong too. > Bruce -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message