Date: Mon, 24 Aug 2015 12:23:29 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824102328.GC93486@ivaldir.etoilebsd.net> In-Reply-To: <20150824094539.GA77434@FreeBSD.org> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org> <20150824084807.GA93486@ivaldir.etoilebsd.net> <20150824090104.GB93486@ivaldir.etoilebsd.net> <20150824094539.GA77434@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--p2kqVDKq5asng8Dg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 24, 2015 at 09:45:39AM +0000, Alexey Dokuchaev wrote: > On Mon, Aug 24, 2015 at 11:01:04AM +0200, Baptiste Daroussin wrote: > > On Mon, Aug 24, 2015 at 10:48:07AM +0200, Baptiste Daroussin wrote: > > > On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote: > > > > [...] > > > > That said, OSVERSION < 900014 will not always be false. And why do= you > > > > want to be rude to our users and deliberately break things just bec= ause > > > > we no longer promise that they will work? > > >=20 > > > Even in that case, this is wrong anyway as you enforce GCC while shou= ld > > > should require a modern compiler via compiler.mk. >=20 > I've thought of Uses/compiler.mk, but eventually couldn't decide which > compiler to ask for: the problem in my case was not with the code (so it > is not like "port needs a compiler understanding C++0X/C++11/C++14", but > the bugginess of GCC 4.2.1 itself. (Now that I'm reading through it agai= n, > compiler:openmp looks interesting). >=20 > Or there's a way to require a modern compiler thish is not feature-based? Not yet, but could be added, I would add compiler:c11 in your case (even if= you are not requiring c11 itself.) >=20 > > Btw that would even be nicer to only use compiler.mk feature as it will > > give this port a chance to work on supported freebsd version on some > > tiers-2 architecture which depends on gcc 4.2.1: mips, powerpc, sparc64, > > etc. While your patch only gives a chance for it to work on unsupported > > version :) >=20 > Certainly, and usually I try to be careful about tiers-2. In this case, > however, I'd have to find a way to de-SSE2'ize the code beforehand; it is > on my list, but quite of low priority. >=20 > ./danfe Sure :) Best regards, Bapt --p2kqVDKq5asng8Dg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXa8KAACgkQ8kTtMUmk6Ew/rwCgu3W5xjDI3h2kRHRsrgTwJcJn YZgAoI/oD0cpJYpnRvyz9ibf/LYqreUM =EqGb -----END PGP SIGNATURE----- --p2kqVDKq5asng8Dg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150824102328.GC93486>