From owner-svn-ports-head@freebsd.org Mon Aug 24 10:23:33 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E0DC9BE683; Mon, 24 Aug 2015 10:23:33 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22c.google.com (mail-wi0-x22c.google.com [IPv6:2a00:1450:400c:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3454C7AC; Mon, 24 Aug 2015 10:23:33 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wijp15 with SMTP id p15so72924540wij.0; Mon, 24 Aug 2015 03:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=fDSgMvKM60G9mACtBXxS4H8k/evYuC0pJB9AAI9P3dc=; b=smUyU1uy/QjP51U5Ex9J7U3pI8sDCoYGYxkTRPCJvkhvQf7T+sU/ouV2fyPa2YPA6l Q0GqeK8FDSJrKi+fdwAks1nSfPNwXDLRWeItjP2zd3worS6in3KuE2yhV++26x7Ace97 agTYniht+hEZTgFHSwbkcNWyZhfOKnBhzbLV5rpaM5+ECXee76lGwha9XQn0PNmVKve9 06pdfj2zQFbpxVap6eKBGBYggoOx4PPfiHyCHBVDix3RKzRvpdp1IZNHTrPTe9QpERjO 3CESkpwNiJn06Dsd6P6hj0q8OFw0rfeytBlasNmXRQsvu4U9TTjM2JAU5bE2j1S96QeN 3xCw== X-Received: by 10.180.96.230 with SMTP id dv6mr28325157wib.23.1440411811692; Mon, 24 Aug 2015 03:23:31 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id n6sm15496939wix.1.2015.08.24.03.23.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2015 03:23:30 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 24 Aug 2015 12:23:29 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824102328.GC93486@ivaldir.etoilebsd.net> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org> <20150824084807.GA93486@ivaldir.etoilebsd.net> <20150824090104.GB93486@ivaldir.etoilebsd.net> <20150824094539.GA77434@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p2kqVDKq5asng8Dg" Content-Disposition: inline In-Reply-To: <20150824094539.GA77434@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 10:23:33 -0000 --p2kqVDKq5asng8Dg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 24, 2015 at 09:45:39AM +0000, Alexey Dokuchaev wrote: > On Mon, Aug 24, 2015 at 11:01:04AM +0200, Baptiste Daroussin wrote: > > On Mon, Aug 24, 2015 at 10:48:07AM +0200, Baptiste Daroussin wrote: > > > On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote: > > > > [...] > > > > That said, OSVERSION < 900014 will not always be false. And why do= you > > > > want to be rude to our users and deliberately break things just bec= ause > > > > we no longer promise that they will work? > > >=20 > > > Even in that case, this is wrong anyway as you enforce GCC while shou= ld > > > should require a modern compiler via compiler.mk. >=20 > I've thought of Uses/compiler.mk, but eventually couldn't decide which > compiler to ask for: the problem in my case was not with the code (so it > is not like "port needs a compiler understanding C++0X/C++11/C++14", but > the bugginess of GCC 4.2.1 itself. (Now that I'm reading through it agai= n, > compiler:openmp looks interesting). >=20 > Or there's a way to require a modern compiler thish is not feature-based? Not yet, but could be added, I would add compiler:c11 in your case (even if= you are not requiring c11 itself.) >=20 > > Btw that would even be nicer to only use compiler.mk feature as it will > > give this port a chance to work on supported freebsd version on some > > tiers-2 architecture which depends on gcc 4.2.1: mips, powerpc, sparc64, > > etc. While your patch only gives a chance for it to work on unsupported > > version :) >=20 > Certainly, and usually I try to be careful about tiers-2. In this case, > however, I'd have to find a way to de-SSE2'ize the code beforehand; it is > on my list, but quite of low priority. >=20 > ./danfe Sure :) Best regards, Bapt --p2kqVDKq5asng8Dg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXa8KAACgkQ8kTtMUmk6Ew/rwCgu3W5xjDI3h2kRHRsrgTwJcJn YZgAoI/oD0cpJYpnRvyz9ibf/LYqreUM =EqGb -----END PGP SIGNATURE----- --p2kqVDKq5asng8Dg--