From owner-freebsd-current@FreeBSD.ORG Sat Aug 12 12:54:35 2006 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 197A516A4DA for ; Sat, 12 Aug 2006 12:54:35 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 74BCC43D53 for ; Sat, 12 Aug 2006 12:54:33 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 776CB51393; Sat, 12 Aug 2006 14:54:27 +0200 (CEST) Received: from localhost (dkx242.neoplus.adsl.tpnet.pl [83.24.27.242]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 4641350EA7; Sat, 12 Aug 2006 14:54:14 +0200 (CEST) Date: Sat, 12 Aug 2006 14:53:08 +0200 From: Pawel Jakub Dawidek To: Dmitry Morozovsky Message-ID: <20060812125308.GA2351@garage.freebsd.pl> References: <20060812152011.H25511@woozle.rinet.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <20060812152011.H25511@woozle.rinet.ru> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: current@FreeBSD.org Subject: Re: gjournal panic on RELENG_6 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2006 12:54:35 -0000 --xXmbgvnjoT4axfJE Content-Type: multipart/mixed; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 12, 2006 at 03:24:04PM +0400, Dmitry Morozovsky wrote: > Hi there >=20 > remounting gjournalled filesystem read-only leaves some kernel structures= =20 > unflushed, leading to a panic. >=20 > Reproduce sequence: >=20 > /ar is gjournalled >=20 > mount -t devfs devfs /ar/tmp > mount -u -r /ar >=20 > ... after several seconds (I suppose on gjournal switch) kernel panicked: Thanks. The attached patch should fix the problem. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: attachment; filename="g_journal_readonly.patch" --- g_journal.c.orig Sat Aug 12 14:52:13 2006 +++ g_journal.c Sat Aug 12 14:08:57 2006 @@ -2850,6 +2850,8 @@ TAILQ_FOREACH(mp, &mountlist, mnt_list) { if (mp->mnt_gjprovider == NULL) continue; + if (mp->mnt_flag & MNT_RDONLY) + continue; desc = g_journal_find_desc(mp->mnt_stat.f_fstypename); if (desc == NULL) continue; --cWoXeonUoKmBZSoM-- --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFE3c80ForvXbEpPzQRAix8AJ9pOybrMZMewcx2E5zKaIW3a75/sQCgr/KE 6pPzn7TV+N5wp/olK9Zgpm4= =J70A -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE--