From owner-svn-ports-all@FreeBSD.ORG  Sat Nov  2 03:13:30 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 3D854182;
 Sat,  2 Nov 2013 03:13:30 +0000 (UTC)
 (envelope-from villa.alberto@gmail.com)
Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com
 [IPv6:2a00:1450:400c:c05::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 417152B63;
 Sat,  2 Nov 2013 03:13:29 +0000 (UTC)
Received: by mail-wi0-f174.google.com with SMTP id cb5so1845289wib.1
 for <multiple recipients>; Fri, 01 Nov 2013 20:13:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=77gkU2bNz8mQjiXXH2+WHrzp1WlWOsRWo6r3W4G4Vxw=;
 b=bznNkqlxslebHhAk9M3bTyTNMEcb0/t15TUaNLk9YTfvcBXw1GR/xDQ9euC/Rxv5Rg
 KWKcPGSqHJqDKEt3Fhn76M21afIoANN8XC+E5J3eq48wB728rGPmmwa2N2RmPqdGud0/
 2ijXPybjEx2lUVCQjjI1YHw3HnF1WLzzIA9uJyjd4GzUBiJpWrbwDrV186IPN/DFcm+O
 xomUDMGBHsPEFFAdcX2ldM5fqKYeiHtyRYGIs3/AhCHkFxDhmC6rX98syQE+epRJG13h
 SiQY35KZLcusc2pi5XP9xNL8hmHq9TYDvOVhmI/Dv8ZK9mpVslWMM1FB/3PJnKctnl/k
 aoyQ==
X-Received: by 10.180.79.230 with SMTP id m6mr4424493wix.19.1383362007452;
 Fri, 01 Nov 2013 20:13:27 -0700 (PDT)
MIME-Version: 1.0
Sender: villa.alberto@gmail.com
Received: by 10.216.30.12 with HTTP; Fri, 1 Nov 2013 20:13:07 -0700 (PDT)
In-Reply-To: <201310311907.r9VJ7cSi018085@svn.freebsd.org>
References: <201310311907.r9VJ7cSi018085@svn.freebsd.org>
From: Alberto Villa <avilla@FreeBSD.org>
Date: Sat, 2 Nov 2013 04:13:07 +0100
X-Google-Sender-Auth: MAa9ZbghdwhoSzP80_oN3Qu5Zw0
Message-ID: <CAJp7RHanHqH+=sCazgEKK3HuZk2CO03msvFE+ST7wrACMr7LPg@mail.gmail.com>
Subject: Re: svn commit: r332275 - in head/Mk: . Scripts
To: Matthias Andree <mandree@freebsd.org>,
 Baptiste Daroussin <bapt@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2013 03:13:30 -0000

On Thu, Oct 31, 2013 at 8:07 PM, Matthias Andree <mandree@freebsd.org> wrote:
> Log:
>   bsd.stage.mk: Fewer false positives, much faster, easier maintenance.

check-stagedir.sh has some issues:

- It requires MTREE_FILE, thus not respecting NO_MTREE.

- It fails with ports relying on an additional "mtree port" (like
ports depending on gnomehier or kdehier4, e.g., multimedia/phonon). I
understand this is not an easy one, so I don't pretend to see it
fixed; or should we make them real mtree files (e.g.,
BSD.kde4.dist...)?

While here, bsd.stage.mk should be enclosed in post-makefile checks,
just like bsd.pkgng.mk, for completeness.
-- 
Alberto Villa, FreeBSD committer <avilla@FreeBSD.org>
http://people.FreeBSD.org/~avilla