From owner-svn-src-all@freebsd.org Tue Aug 11 22:31:05 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABDD73B8ED9; Tue, 11 Aug 2020 22:31:05 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BR6xP1cPGz47wx; Tue, 11 Aug 2020 22:31:05 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-il1-x133.google.com with SMTP id j9so12447907ilc.11; Tue, 11 Aug 2020 15:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h4z1ythjTQltk4n9byFjedZB9PeF7lFVnzRlKs/IL2M=; b=Dx+5tqmYfY3lSXxTgnJ6TBx3BdZO2/rAvfX9NdDqXqA19xj+yAWamFdrpoP/9ACrBL XSegg6bckbIdelyRtuycX3xzZFxBXV51DfDBuzDawGPieoVn61tsRweZkuL8fJj0byzh ZSmmH+un0N+S82cdbY1nobmxszl3DVpSmiqrL2KHrGLJ+ibAth5Gn5e+TvAyb4nQsfTQ kLG/vcV3gDZnVbM+xab4zHOG/vuu6ETk+t6MetNHLlyurb7cz3M0s5LbInRokPNuvWLp jJGoKf42nlh6n+kU6guoe6ZInLlEY7l6ZPthjJHd8RBOcZmqHJrJ2nrTY6V8P1GyXpvP 0KCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=h4z1ythjTQltk4n9byFjedZB9PeF7lFVnzRlKs/IL2M=; b=RfDLOre7RJeMVefIXYMKGcinej/g3tTEBoGA57dHEmS7T9+a30ZJUpNc2qNp7aqlKT C5xnjd1J3e+u5MyssgZeUo3m5jQPiKM8ouB0fRoHyaZy/jAtfVQzIVjFyJNfwp+CqCuS 3EyW3BkEHlBtoSFxf+FRXvmd5UTX9N+HhfCMGEffV3cgKhZi3VTWseNec1Mmk6XlEr7s hKd2HeIbjrTZTW2F+NRsqOeZR5CpjSfxNnCAxbPeMkwH49S0HhvWtLVIN5JnuErDZjgn 3s4wv724T3aG7S4ffJ4UuWdDfAppvovMskijvM7VQHee16d+p3UkltPmcVi4fPQe6Utw Oc8g== X-Gm-Message-State: AOAM53025uY06+mwgHXdWQc3UduvonT3CKZZpQUQ+dd3lTFXWzWzZxwL HuQKLFMY9M0gFynNW4frkt4RS/CI X-Google-Smtp-Source: ABdhPJzvCuvcCSzAMKwRGZPwbhqa+KChh22qNhno/cxc3gqK2BUrxWAtQep6UoYtM5gxQO3422pZBw== X-Received: by 2002:a92:c092:: with SMTP id h18mr4428786ile.178.1597185063330; Tue, 11 Aug 2020 15:31:03 -0700 (PDT) Received: from raichu (toroon0560w-lp130-08-67-71-176-35.dsl.bell.ca. [67.71.176.35]) by smtp.gmail.com with ESMTPSA id t187sm46771iof.54.2020.08.11.15.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 15:31:02 -0700 (PDT) Sender: Mark Johnston Date: Tue, 11 Aug 2020 18:31:00 -0400 From: Mark Johnston To: Conrad Meyer Cc: Konstantin Belousov , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r364129 - head/sys/vm Message-ID: <20200811223100.GC77647@raichu> References: <202008112037.07BKbjsL056699@repo.freebsd.org> <20200811213213.GT2551@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4BR6xP1cPGz47wx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 22:31:05 -0000 On Tue, Aug 11, 2020 at 03:21:31PM -0700, Conrad Meyer wrote: > Hi Konstantin, Mark (raised the same question), > > On Tue, Aug 11, 2020 at 2:32 PM Konstantin Belousov wrote: > > > > On Tue, Aug 11, 2020 at 08:37:45PM +0000, Conrad Meyer wrote: > > > Author: cem > > > Date: Tue Aug 11 20:37:45 2020 > > > New Revision: 364129 > > > URL: https://svnweb.freebsd.org/changeset/base/364129 > > > > > > Log: > > > Add support for multithreading the inactive queue pageout within a domain. > > > ... > > > @@ -2488,7 +2488,7 @@ vm_page_zone_import(void *arg, void **store, int cnt, > > > * main purpose is to replenish the store of free pages. > > > */ > > > if (vmd->vmd_severeset || curproc == pageproc || > > > - !_vm_domain_allocate(vmd, VM_ALLOC_NORMAL, cnt)) > > > + !_vm_domain_allocate(vmd, VM_ALLOC_SYSTEM, cnt)) > > > > Why this change needed ? > > The change was inherited from Jeff, along with the rest of it. I > don't know why he changed it, but it does seem orthogonal to the rest > of the revision. This part is nonessential as far as I know, and > could be backed out. To me it doesn't make sense. The difference between VM_ALLOC_NORMAL and _SYSTEM is that they use different thresholds for the free page count before deciding whether to continue the allocation. The _NORMAL threshold is higher than the _SYSTEM threshold, but both are smaller than the "severe" threshold at which we set vmd_severeset. In other words, if the free page count is such that a _NORMAL allocation would fail but a _SYSTEM allocation would succeed, then vmd_severeset would be set and we'd never get to the _vmd_domain_allocate() call to begin with. So, I think this part of the change should be reverted. Even if the analysis is incorrect, it's logically separate from the rest of the diff. Prior to r355003 it made more sense, but per that commit it can be harmful to populate the per-CPU page caches when the system is severely short on free pages, so I would disagree with it anyway without more testing.