From nobody Tue Jul 21 07:08:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h47lB0MLTz6ljv6 for ; Tue, 21 Jul 2026 07:08:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h47l94KfFz3PV7 for ; Tue, 21 Jul 2026 07:08:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784617701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9dw1qjE/vifPyVOCiKPgbGf8nBWwA4XF+ZrqLHeBpCo=; b=N+QdwBT5w+UMHAU+X5V+IYK2w08VH5m+JGG4l008XFsjbZ7gmtYwT/gVTK7lDZuN8qYtT7 6iDXrFS0TnGYrk7sLXbrT+6AwPFlIBPm+nse5ufcRTsyMcnrGnFiBjv2bjeRCS/piQbiai kMescMyLXD1YxCpGX0jrr0ZFgAdDRcAOMgaVj2bxTYu6d8DBv4WPHH9kd0WFiqdLZ8s8dz IEd7YgWqHjtSP5JDes4MVQrCUb7oEpq+lds8O/lCsmCcOTAAgi36i0IoIied6ukSzRc0uE DMtTAC7DI4JvsWu1lyl3a8bzVSaDfUicK3bLbBtGijv29CMdtVmkT+sZ8HaEig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784617701; a=rsa-sha256; cv=none; b=kE2HoyoYugR5dDJDddA7GJ1GSzutZrJBJ+JmQez2wfCsHWzzP1qjqzHwtvuFLzgety5pUm zuYYZ0Jq/nzIEnCOOQ/XHDWTexwv/HeXwIsCV5Qy3/KrPfXVuC9rRtKiKrns+KHwGbj1qO 6V+5uMW6CVxXLotVc0ijWSCkFBXOMezAZWsjRaA7aOyv94v5GA+LsXXRp8grti3KLlPkAW 0cR+QUK5zj+OCigebyTbW2SBEFKkotf1v8/eErF3ED9gjGdezhXGq4DmMV4vbNPdzABKVa p4ryJRdYy9WZyZ9VBxneA+j4CE7dIQM7AKi07gOlOat19/e9srsYnxFq3EqrrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784617701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9dw1qjE/vifPyVOCiKPgbGf8nBWwA4XF+ZrqLHeBpCo=; b=eVr35YEx5CWV/WAqSarTkB+g9I7egl74wLkQ7eHt8NU4OQtDe4w2qiM6wAfLPycjoNgce0 wr9UpX0dlrarBybZy58JBsB0+LCAVPBh2WJ09zpfdAIKYOsPPqSzGX4acP5HgI6euRV9+w zIP6IwLPMMpYSYb4zJfdge8Zt1St1ioPoptEhynQQ2KklwNkR43eN2BgTWHNJggKEBPbUU hrs9AjlJb8zeq36lhGlloc/U52rbKXAoiYCha8+KJwfliLKAaNaKXLu+d2pqipsi+u9/UR 6NxBfAqPlK/RrCBrUxOT9e66VFdSMv4/0qf3r3d882zHxRxCd5BQIVwRU/meZg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h47l91crWzdpn for ; Tue, 21 Jul 2026 07:08:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44ba8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 21 Jul 2026 07:08:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Toomas Soome Subject: git: a0486017c2a4 - main - bhyve: check upper bounds for value from qsz List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tsoome X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a0486017c2a453ce5e8b6e678a14e7d5577c1300 Auto-Submitted: auto-generated Date: Tue, 21 Jul 2026 07:08:21 +0000 Message-Id: <6a5f1ae5.44ba8.3df9ddeb@gitrepo.freebsd.org> The branch main has been updated by tsoome: URL: https://cgit.FreeBSD.org/src/commit/?id=a0486017c2a453ce5e8b6e678a14e7d5577c1300 commit a0486017c2a453ce5e8b6e678a14e7d5577c1300 Author: Toomas Soome AuthorDate: 2026-07-21 06:33:38 +0000 Commit: Toomas Soome CommitDate: 2026-07-21 06:33:38 +0000 bhyve: check upper bounds for value from qsz The max_qentries in pci_nvme_softc is uint16_t and too large int may get truncated to invalid value. While there, use local declarations for val. Suggested by: Bill Sommerfeld Reviewed by: chuck Differential Revision: https://reviews.freebsd.org/D58293 --- usr.sbin/bhyve/pci_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 3656ee7a8d65..b2b9f0ff88a8 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3185,7 +3185,7 @@ pci_nvme_parse_config(struct pci_nvme_softc *sc, nvlist_t *nvl) value = get_config_value_node(nvl, "qsz"); if (value != NULL) { val = atoi(value); - if (val <= 0) { + if (val <= 0 || val > UINT16_MAX) { EPRINTLN("nvme: Invalid qsz option %d", val); return (-1); }