Date: Thu, 09 Jun 2022 01:52:32 +0000 From: bugzilla-noreply@freebsd.org To: doc@FreeBSD.org Subject: [Bug 264562] New Account Creation Procedure: corrections Message-ID: <bug-264562-9-Jppe0Ipkuo@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-264562-9@https.bugs.freebsd.org/bugzilla/> References: <bug-264562-9@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264562 --- Comment #2 from Graham Perrin <grahamperrin@gmail.com> --- <https://docs.freebsd.org/en/articles/committers-guide/#commit-steps>; for n= ew committers there's a ten-step Procedure 1 =E2=80=93 however as far as I can tell, there's no second procedure (2) any= where in the article.=20 For me, as a new committer with a bit for doc, step 5 of 10 should be:=20 src/share/misc/committers-doc.dot =E2=80=93 with mentor approval before the commit.=20 ---- Pause for thought. Re: comment 0, here's the single-paragraph section of the page in its entirety:=20 > After the new committer confirms that the account works, the mentor=20 > adds the new committer to the correct access file, using an appropriate=20 > commit message. The commit message should at least contain the committer= =E2=80=99s=20 > full name and username, the mentor=E2=80=99s name and what area the new c= ommitter=20 > will start to work in. An entry should also be added to the mentors file= =20 > in the respective Git repository to indicate the mentor relationship.=20 > Having done all that, the new committer and mentor jointly go through the= =20 > first commit operations. The final sentence is for joint actions, _first_ commit operations.=20 For the preceding sentence, it's implicit that addition "to indicate the me= ntor relationship" is performed by a mentor alone =E2=80=93 _not_ a joint action= .=20 ---- However, _joint_ step 5 of 10 is an addition to indicate the mentor relationship. Two examples:=20 <https://github.com/freebsd/freebsd-src/commit/b46595affce8c1905c4cd43f1e98= 53bbb9a4a05f> <https://github.com/freebsd/freebsd-src/commit/bffc3fb3c09b36fd8740242f184d= 1e8bd8530920> If it's true that the new account creation procedure contradicts the Committer's Guide, then I'm inclined to:=20 1. treat the setup section of Committer's Guide as definitive 2. make <https://www.freebsd.org/internal/new-account/>=20 consistent, and a little clearer. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-264562-9-Jppe0Ipkuo>