From owner-svn-ports-head@FreeBSD.ORG Fri Aug 1 06:32:43 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 0EE6F4C1; Fri, 1 Aug 2014 06:32:43 +0000 (UTC) Date: Fri, 1 Aug 2014 06:32:43 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <20140801063243.GE71116@FreeBSD.org> References: <6270029E710D3C52B60B6224@atuin.in.mat.cc> <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org> <20140801060506.GA71116@FreeBSD.org> <53DB3021.7010909@marino.st> <20140801062047.GC71116@FreeBSD.org> <53DB32E8.7020700@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53DB32E8.7020700@marino.st> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-ports-head@freebsd.org" , Max Brazhnikov , Antoine Brodin , "svn-ports-all@freebsd.org" , William Grzybowski , "ports-committers@freebsd.org" , Mathieu Arnold , Adam Weinberger X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 06:32:43 -0000 On Fri, Aug 01, 2014 at 08:25:44AM +0200, John Marino wrote: > On 8/1/2014 08:20, Alexey Dokuchaev wrote: > > Basically right now one patch will overwrite another conflicting one, which > > ever comes first. I think I can add a check beforea > $${OUT} and issue an > > error and refuse to overwrite a file, or maybe just warn. Which you prefer? > > Neither. I prefer the original character escaped with itself You may > not like this, but something like: [...] You're right, I don't. :-) However, I will implement autoexpantion (char -> charchar) since it doesn't add too much complexity. > Thoughts? any potential of overwritting is bad. Well, my original idea (bail out with an error) is how I saw we prevent overwriting: by asserting that output file does not exist; you think it is not robust enough? ./danfe