From owner-svn-src-all@FreeBSD.ORG  Mon Apr 18 19:42:38 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1B548106566C;
	Mon, 18 Apr 2011 19:42:38 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id D53E28FC15;
	Mon, 18 Apr 2011 19:42:37 +0000 (UTC)
Received: by pwj8 with SMTP id 8so3101733pwj.13
	for <multiple recipients>; Mon, 18 Apr 2011 12:42:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=Z3kM/MO964Xm37dkeWXpZMez+bX+39wwKZnyQrQhOB0=;
	b=CXpX0fjl2oDB7WmmomkwPpIPLIJBZvFpUlrYpbcAfn24MJWkcFu53zjQ/00+ZEypZw
	crgMIlLo5JDsV2jtqIJZ4kBgrpcelJAnMm7L3S4RlABvqZ0KcqthKcE/4GhT8ObMId5M
	sxPxEOyU3UlnmcwyOuTOFcnLLIbE0sKR5tTew=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=CPWcHUNviHn2sM+jaAo1vgrUronMCkuSWVf8Ivk3fspYbn2FXdMWGgxHA+l1L1/lKf
	EeGrk3CVRCSaymuanbw9sUQdwou32CaKAIe1Jug1K8JNiRyb8MIvP8oODBeaF2tdtJGf
	AMmyMSQYuE8Tw0GMHhjV31QEo3k2S2gteVYw8=
MIME-Version: 1.0
Received: by 10.68.2.132 with SMTP id 4mr7353764pbu.11.1303155757401; Mon, 18
	Apr 2011 12:42:37 -0700 (PDT)
Received: by 10.68.42.3 with HTTP; Mon, 18 Apr 2011 12:42:37 -0700 (PDT)
In-Reply-To: <20110418181314.GL16958@FreeBSD.org>
References: <201104170605.p3H65cab028890@svn.freebsd.org>
	<20110418181314.GL16958@FreeBSD.org>
Date: Mon, 18 Apr 2011 12:42:37 -0700
Message-ID: <BANLkTimCdHqdn2672cXDWqECUnSc4hV38Q@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, Maxim Sobolev <sobomax@freebsd.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r220736 - head/sbin/natd
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2011 19:42:38 -0000

2011/4/18 Gleb Smirnoff <glebius@freebsd.org>:
> On Sun, Apr 17, 2011 at 06:05:38AM +0000, Maxim Sobolev wrote:
> M> Author: sobomax
> M> Date: Sun Apr 17 06:05:37 2011
> M> New Revision: 220736
> M> URL: http://svn.freebsd.org/changeset/base/220736
> M>
> M> Log:
> M> =A0 If we can retrieve interface address sleep for one second and try =
again.
> M> =A0 This can happen during start-up, when natd starts before dhclient =
has a
> M> =A0 chance to receive IP address from the upstream provider.
> M>
> M> =A0 MFC after: 2 weeks
>
> This looks like a hack and better place for this hack would be shell
> scripts rather than nat daemon.

    +1 -- in particular because this will affect all cases, and not
just the dhclient-acquired IP external NIC case as the above commit
message notes.
Thanks,
-Garrett