From owner-freebsd-arch@FreeBSD.ORG  Mon Jan  9 08:52:33 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 835D5106566C;
	Mon,  9 Jan 2012 08:52:33 +0000 (UTC) (envelope-from stb@lassitu.de)
Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea])
	by mx1.freebsd.org (Postfix) with ESMTP id 420E18FC1D;
	Mon,  9 Jan 2012 08:52:33 +0000 (UTC)
Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 040A811AB41;
	Mon,  9 Jan 2012 08:52:31 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Stefan Bethke <stb@lassitu.de>
In-Reply-To: <CAJ-VmomWF6g1kgrzKxvsveeOjc-sNoKNoL090331+wV4OPSAfw@mail.gmail.com>
Date: Mon, 9 Jan 2012 09:52:30 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <DFFFE611-01A1-4B3F-8DFF-72E410483D5D@lassitu.de>
References: <CAJ-Vmom08uFV+NMryjZon_xnqo95MAK8r2=0s_JqRet7EMdn4g@mail.gmail.com>
	<09C21BD6-46E1-4593-9E3C-183CF229A613@lassitu.de>
	<CAJ-VmomWF6g1kgrzKxvsveeOjc-sNoKNoL090331+wV4OPSAfw@mail.gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
X-Mailer: Apple Mail (2.1084)
Cc: freebsd-arch@freebsd.org
Subject: Re: Where should I put ar71xx_* modules?
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2012 08:52:33 -0000

Am 09.01.2012 um 09:39 schrieb Adrian Chadd:

> On 8 January 2012 23:59, Stefan Bethke <stb@lassitu.de> wrote:
>> Am 09.01.2012 um 00:42 schrieb Adrian Chadd:
>>=20
>>> Hi,
>>>=20
>>> In order to fit an lzma'd kernel in 892 kilobytes of flash (that's =
892
>>> * 1024 bytes), I've needed to break out a few things into modules.
>>>=20
>>> I'd like to commit a couple of modules - for example,
>>> ar71xx_ehci/ar71xx_ohci for USB stuff - but I don't want them built
>>> for anything other than ar71xx builds. Thus I don't see the reason =
for
>>> putting them in sys/modules/Makefile.
>>>=20
>>> They build fine if they're included in MODULES_OVERRIDE in the
>>> relevant kernel config file.
>>>=20
>>> So is it ok to just commit some modules in sys/modules/ which aren't
>>> in the Makefile, and instead include them in the relevant SoC kernel
>>> configs so they're built? Or is there some other tradition for doing
>>> this?
>>=20
>> Why would it hurt to have them connected to the standard build?  Doe =
the tinderboxes build modules?
>=20
> Because they have to compile only for MIPS? And they'd only work for =
ar71xx?

We have lots of modules that have specific requirements; they're still =
connected to the build.  What warrants different handling here?  You =
could put them under .if ${MACHINE_CPUARCH} !=3D "mips" like a number of =
them are already.


Stefan

--=20
Stefan Bethke <stb@lassitu.de>   Fon +49 151 14070811