From owner-svn-src-all@FreeBSD.ORG Sun Jul 31 18:59:40 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84924106566B; Sun, 31 Jul 2011 18:59:40 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 05BBD8FC19; Sun, 31 Jul 2011 18:59:39 +0000 (UTC) Received: by gwb15 with SMTP id 15so4222216gwb.13 for ; Sun, 31 Jul 2011 11:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=swMFgGff8N5t0F2Egf9fDDtXLQJrPr1ZD1Uc2wS9C38=; b=jB6VhHSe0aIOEkmEEBfs4FXMFCMKHq31HV1Io1u8N4Qyt1mXxipQ03+hsSUuyaPwxN cM8Fh3po1059ZPWmbISh3J+UFCpVPq9uRH0KotpBw3jYTJ+TfMDjFiRJlHfCKuNSYX2B XIxvFaunVn7ytqlFGIRW5LaNCqpBABEzIYQIo= MIME-Version: 1.0 Received: by 10.236.186.7 with SMTP id v7mr2396225yhm.294.1312138779154; Sun, 31 Jul 2011 11:59:39 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.109.13 with HTTP; Sun, 31 Jul 2011 11:59:39 -0700 (PDT) In-Reply-To: <6C5FFE5F-7BF6-4347-8442-8DE0F4E13D2E@xcllnt.net> References: <201107311826.p6VIQlFa058340@svn.freebsd.org> <6C5FFE5F-7BF6-4347-8442-8DE0F4E13D2E@xcllnt.net> Date: Sun, 31 Jul 2011 14:59:39 -0400 X-Google-Sender-Auth: mPGZ8zAsohHizqgBBnQHdzzDZmU Message-ID: From: Attilio Rao To: Marcel Moolenaar Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org Subject: Re: svn commit: r224551 - head/sys/powerpc/booke X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2011 18:59:40 -0000 2011/7/31 Marcel Moolenaar : > > On Jul 31, 2011, at 11:27 AM, Attilio Rao wrote: > >> I actually submitted a better fix which does use .int. >> I wasn't sure BETA1 was out, so I'm going to send a formal request now. > > Maybe we should just let it be. I don't see anything > superior with using .int that .long didn't already > fix. If anything, we could end up breaking stuff and > then having to fix it again. > > Any reason to go back in and change it again that I > can't see? Besides extending the fix to arm and mips, size_t is typedefed as int and not as long, thus I think it is more correct semantically. Pratically speaking, for booke, it doesn't change anything though. As you have the blanket on powerpc I'll do what you prefer for it, the patch is here: http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein