Date: Fri, 30 May 2014 12:03:16 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: John Marino <marino@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r355806 - head/x11-themes/clearlooks-themes-extras Message-ID: <CAALwa8nX_O7nsFix1eWA7D4dpVu3z9erwG3_2JAJQCXYaQjReg@mail.gmail.com> In-Reply-To: <53885290.20102@marino.st> References: <201405300923.s4U9N2SU054380@svn.freebsd.org> <CAALwa8k-48YpPwA2qiMw%2BfwmdE4QJ=JHBkv=tSv2XUpWAPAFKA@mail.gmail.com> <53885290.20102@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 30, 2014 at 11:42 AM, John Marino <freebsd.contact@marino.st> wrote: > On 5/30/2014 11:31, Antoine Brodin wrote: >> On Fri, May 30, 2014 at 11:23 AM, John Marino <marino@freebsd.org> wrote: >>> Author: marino >>> Date: Fri May 30 09:23:02 2014 >>> New Revision: 355806 >>> URL: http://svnweb.freebsd.org/changeset/ports/355806 >>> QAT: https://qat.redports.org/buildarchive/r355806/ >>> >>> Log: >>> x11-themes/clearlooks-themes-extras: Stage support+ >>> >>> In addition to supporting stage, the unnecessarily custom extraction >>> target was replaced with NO_WRKSUBDIR. >>> >>> Modified: >>> head/x11-themes/clearlooks-themes-extras/Makefile >> >> Hi, >> >> This looks wrong: >> - creates a directory outside of stagedir during install > > I missed "@${MKDIR} ${THEME_DIR}" => "@${MKDIR} ${STAGEDIR}${THEME_DIR}" > unfortunately redports didn't complain > > >> - use of NO_WRKSUBDIR + cd ${WRKSRC} && ${FIND} . ... is usually harmfull > > why? I would have used COPYTREE or something myself but I don't see > anything immediately wrong with this. Run "make check-plist" or "make check-orphans" and you will see that unexpected files end up in stagedir. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8nX_O7nsFix1eWA7D4dpVu3z9erwG3_2JAJQCXYaQjReg>