From owner-freebsd-net@FreeBSD.ORG  Mon Mar  5 14:21:07 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@FreeBSD.org
Delivered-To: freebsd-net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 091CA16A401;
	Mon,  5 Mar 2007 14:21:07 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from out5.smtp.messagingengine.com (out5.smtp.messagingengine.com
	[66.111.4.29])
	by mx1.freebsd.org (Postfix) with ESMTP id D0E1D13C442;
	Mon,  5 Mar 2007 14:21:06 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from out1.internal (unknown [10.202.2.149])
	by out1.messagingengine.com (Postfix) with ESMTP id 59F101F5BCA;
	Mon,  5 Mar 2007 09:21:06 -0500 (EST)
Received: from heartbeat1.messagingengine.com ([10.202.2.160])
	by out1.internal (MEProxy); Mon, 05 Mar 2007 09:21:06 -0500
X-Sasl-enc: VDDtqdCIm7LyV5kOtEHPkRgRcYXTlRZHt4gxeNkGimM5 1173104466
Received: from [192.168.123.18]
	(82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254])
	by mail.messagingengine.com (Postfix) with ESMTP id ACE8423F7F;
	Mon,  5 Mar 2007 09:21:05 -0500 (EST)
Message-ID: <45EC274F.7090201@FreeBSD.org>
Date: Mon, 05 Mar 2007 14:21:03 +0000
From: "Bruce M. Simpson" <bms@FreeBSD.org>
User-Agent: Thunderbird 1.5.0.9 (X11/20070125)
MIME-Version: 1.0
To: Eygene Ryabinkin <rea-fbsd@codelabs.ru>, 
	Andrew Thompson <thompsa@freebsd.org>
References: <E1HNbWw-000LoF-Bo@pobox.codelabs.ru> <45E9F1E8.2000802@inse.ru>
	<20070304062203.GL80319@codelabs.ru>
	<E1HNbWw-000LoF-Bo@pobox.codelabs.ru>
	<45E9F1E8.2000802@inse.ru> <20070304160613.GN80319@codelabs.ru>
	<45EB4915.1090703@FreeBSD.org> <45EB4FD7.2000708@inse.ru>
	<45EB5869.1010100@FreeBSD.org> <20070305125133.GR80319@codelabs.ru>
In-Reply-To: <20070305125133.GR80319@codelabs.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@FreeBSD.org
Subject: Re: kern/109815: wrong interface identifier at pfil_hooks for vlans
 +	if_bridge
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Mar 2007 14:21:07 -0000

Eygene Ryabinkin wrote:
> Will try to understand if it will cure my problem, thanks!
> Attaching my patch, just in case if freebsd gnats will be down ;))
>   

Thanks for this. It looks like Andrew may be in a better position to say 
if this fix should go in or not.

It is possible that if bridge changes the ifp and that the frame should 
be forwarded locally, i.e. to the upper protocol layers, that ifp should 
also be updated in ether_input() (as NetBSD does) to make sure that the 
later checks are against the updated ifp.

I have just changed this behaviour in p4 bms_netdev. Please try to test 
with this code. If you can't access p4, then I can extract an updated 
patch though this will take longer.

This should help to eliminate the need for DEV_CARP compile-time 
conditionals in if_bridge(4).

Regards,
BMS