Date: Sat, 6 Oct 2012 10:40:04 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: ports@FreeBSD.org Subject: Re: [CHANGE PROPOSAL] Moving WWW from pkg-descr to Makefile Message-ID: <20121006084004.GD30675@ithaqua.etoilebsd.net> In-Reply-To: <20121006080409.GA30675@ithaqua.etoilebsd.net> References: <20121005140534.GB61272@ithaqua.etoilebsd.net> <506F9275.3090106@FreeBSD.org> <20121006080409.GA30675@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZARJHfwaSJQLOEUz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 06, 2012 at 10:04:09AM +0200, Baptiste Daroussin wrote: > On Fri, Oct 05, 2012 at 07:07:49PM -0700, Doug Barton wrote: > > On 10/05/2012 07:05 AM, Baptiste Daroussin wrote: > > > Hi, > > >=20 > > > I want to propose and make the actual move of the WWW information fro= m the > > > pkg-descr to the Makefile itself via a WWW variable. > > >=20 > > > doing this will have multiple benefits: > > > * consistency all metadata bug this one are in Makefile > >=20 > > ... except for the distinfo data. > ... > >=20 > > > * speedup make describe avoiding using grep to get the informations = (make > > > describe itself does not need speed but make index heavily use it = and this > > > will definitly benefit from speed up) > >=20 > > Agreed, but there are other ways to speed up 'make describe,' and tools > > like ports-mgmt/p5-FreeBSD-Portindex are a much better solution where > > "create an up to date INDEX quickly" is a real need. >=20 > This sounds like: we have a problem, instead of fixing it let's workaroun= d it >=20 > >=20 > > > * Third party tool will be able to probe the information more easily. > >=20 > > Portmaster doesn't parse WWW for anything, but I have suggested to > > others in the past that 'while read' in sh is a faster method of finding > > the WWW than grep. In fact, 'make describe' uses this method now, not > > grep. I vaguely recall that this was done at my suggestion, but I'm too > > lazy to trace the commit path to confirm it. :) 'make www-site' (which > > already exists in case there is a 3rd party tool that needs it) uses a > > different method utilizing awk. I haven't tested which one is faster. > >=20 > > I'm also concerned about the proliferation of things being jammed into > > the ports Makefile (and coincidentally, bpm). I've noticed that just > > about every operation that portmaster does using 'make -V' has gotten > > noticeably slower over the last 6-8 months, and the trend seems to be > > getting worse instead of better. >=20 > make www-site already exists and will be made faster, and nothing else wi= ll be > added, but things will be removed... I don't see the proliferation here b= ut > rather a cleanup. >=20 > Concerning the bpm, I have removed more old things and useless tests from= it > that I have added! and if people were actively working on switching there= ports > to the new option framework then the fallback code could be removed and t= his > will speed up lots of operations. >=20 > >=20 > > > Do anyone have any concern about this? > >=20 > > For all these reasons, and for the already-stated reason that it > > severely lowers the value of 'cat pkg-descr' (which I do quite often, > > and I'm sure other users do as well) I think this is a bad idea. > >=20 > > Doug > >=20 Here is a diff of the final impact on bpm (once WWW: is gone) regards, Bapt --ZARJHfwaSJQLOEUz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBv7mQACgkQ8kTtMUmk6EyueACfXaEg3BXqGSdGqV5UhK84Qk7o UhAAoLIOfC1evg/ujbz1qlq7yPb6djU4 =ULtd -----END PGP SIGNATURE----- --ZARJHfwaSJQLOEUz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121006084004.GD30675>