Date: Wed, 12 Apr 2023 14:21:40 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Muhammad Moinur Rahman <bofh@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: <ZDa%2BdPM7qCMgDeRs@FreeBSD.org> In-Reply-To: <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3> References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> <ZDa1j/k5bMGxfDH0@FreeBSD.org> <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 12, 2023 at 03:55:00PM +0200, Mathieu Arnold wrote: > On Wed, Apr 12, 2023 at 01:43:43PM +0000, Alexey Dokuchaev wrote: > > On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote: > > > commit c89b6f2799891129e89d1b4fedf8e25865241060 > > > > > > lang/php8[12]: Fix build on aarch64 with ZTS > > > > > > - Refresh patches > > > > What good did it bring other than cloaking the actual fix with tons > > of needless, unrelated changes? You've poured a glass of honey into > > a bucket of tar. :( > > Because that is something you have to do everytime a port is updated, No, you don't, and you shouldn't. Patches come and go all the time, blindly following this "rule" just brings useless noise to the commit diff, nothing else. > refresh the patches so that the line offsets are correct wrt current > sources, to make sure patch(1) can just apply the patches and not > resort to guesswork. If patch(1) cannot apply some patch, it will complain and the port won't build, so existing patches are applicable by definition. But we have already argued about this in the past. I prefer cleaner commit diffs, you don't, oh well. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZDa%2BdPM7qCMgDeRs>