From owner-svn-ports-all@FreeBSD.ORG Fri Aug 1 06:02:23 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE36A7E7; Fri, 1 Aug 2014 06:02:23 +0000 (UTC) Received: from mail-yh0-x22f.google.com (mail-yh0-x22f.google.com [IPv6:2607:f8b0:4002:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2449D29A5; Fri, 1 Aug 2014 06:02:22 +0000 (UTC) Received: by mail-yh0-f47.google.com with SMTP id f10so2291780yha.6 for ; Thu, 31 Jul 2014 23:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=7VMPxVFWyvC5bWDs1w1+CTSEGkkTmjoFgIj9BN+cb98=; b=DPr/S7L7LD0DgqNSDetnStAgs9dO7eKvRoUEQiUKaBPRipZU5aIM6ohj2Jl9zjTACj Ex5NFsDAoGk9M8d5IR6ZOBdNZ6foOHcrfdebasNPoylj+wdTU8tkG6rBZ/ewi6pZGiGA j4ZbexqZ6ouc5hWl3KrXOaWlixS0CtSyFvr/0XfjC+CeIaKJ3/tSwP2CVgsVrsLlU7Cp icyW4quLE8V/jmJeT9Y9fpFBhvg5KEnFylBxd7/7bGcq7/9VcaBqdrRNfDtCYubhWrl9 woBizZt9LPDSppdPLLmoXApYJSdaC8YAccZ1tVZLNikgacaspAnAKP8wr0+nOCAPvM2B DiIg== MIME-Version: 1.0 X-Received: by 10.236.17.194 with SMTP id j42mr4864987yhj.138.1406872941905; Thu, 31 Jul 2014 23:02:21 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.164.197 with HTTP; Thu, 31 Jul 2014 23:02:21 -0700 (PDT) In-Reply-To: <20140801051652.GA59625@FreeBSD.org> References: <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org> Date: Fri, 1 Aug 2014 08:02:21 +0200 X-Google-Sender-Auth: zAHiW3wkeqZTeHGvYuqsj9yZGjg Message-ID: Subject: Re: svn commit: r363361 - in head/editors/fte: . files From: Antoine Brodin To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , Max Brazhnikov , "svn-ports-all@freebsd.org" , John Marino , William Grzybowski , "ports-committers@freebsd.org" , Mathieu Arnold , Adam Weinberger X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 06:02:23 -0000 On Fri, Aug 1, 2014 at 7:16 AM, Alexey Dokuchaev wrote: > On Wed, Jul 30, 2014 at 06:13:48PM +0200, John Marino wrote: >> On 7/30/2014 18:08, Alexey Dokuchaev wrote: >> > Given some thought over it, I propose the following changes to makepatch: >> > >> > - default to dash (minus, '-') >> > - provide a command line option (-s?) or make(1) variable (PATH_SEPARATOR) >> > to override it when needed >> > - assert that forced value is not something insane ('__', '::', '../../', >> > etc.) -- basically, match it over a prerefined list of acceptable values >> > >> > I can cook up a patch unless John had beaten me on that already. >> >> Nope, go for it. > > Have a look (attached). I've also fixed annoying bug (appending of leading > "./" in the ---/+++ lines of generated patches), and improved the comment. Hi, Refusing _ in seperator seems total bullshit, this convention has been in place for 9 years, wtf!? Cheers, Antoine