From owner-svn-src-all@FreeBSD.ORG Tue Apr 20 05:17:03 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5DE6106564A; Tue, 20 Apr 2010 05:17:02 +0000 (UTC) (envelope-from kmatthew.macy@gmail.com) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by mx1.freebsd.org (Postfix) with ESMTP id 741BE8FC16; Tue, 20 Apr 2010 05:17:02 +0000 (UTC) Received: by qyk11 with SMTP id 11so6012039qyk.13 for ; Mon, 19 Apr 2010 22:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:reply-to:received :in-reply-to:references:date:x-google-sender-auth:received :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=WyKz3PMbtNUa818S+rFlLpSOE60Zs9GxLsxWBVJnbl0=; b=gkj4Zk1NZHMg9FKHNBfqo+Dpwei+Z5oMkNJIPp45xDVGdfpSnkODIs3lhsXuR+p8xq Nv2A2Jo7JU3nW4HaY0KMduMe8kg/8Dj6jiP0zfZ7r/8rgZ7IM5RUNH+EJ9MBoJN964Rz X4ReZq7I6nE0Ycg7IQznBiKJCfcymJPROUf2s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:reply-to:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=QAtDzrpD1r6nL7bgYm2IVzljExHsBCd9VwwqICAvwmn0ip0AlFJ30Xc7Yass9lc/ec qlFgfEoGlAyoQYdXd0FYqZhQkECkS21iNqB12wRpTueRWl5zlvDMM8qckVOibK1ZIgQI yaNt9QsA9C2ghEswBhCsJ8nYRoyBnlNJB2+SE= MIME-Version: 1.0 Sender: kmatthew.macy@gmail.com Received: by 10.229.226.6 with HTTP; Mon, 19 Apr 2010 22:17:01 -0700 (PDT) In-Reply-To: <201004031620.o33GKM0n037332@svn.freebsd.org> References: <201004031620.o33GKM0n037332@svn.freebsd.org> Date: Mon, 19 Apr 2010 22:17:01 -0700 X-Google-Sender-Auth: ff152be23782f1de Received: by 10.229.193.18 with SMTP id ds18mr1567774qcb.14.1271740621272; Mon, 19 Apr 2010 22:17:01 -0700 (PDT) Message-ID: From: "K. Macy" To: Alan Cox Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r206140 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: kmacy@freebsd.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2010 05:17:03 -0000 How has the problem been addressed? I'm seeing periodic panics with non-zero resident count with the page lock patch applied. It is possible that I've inadvertently re-introduced an issue you've fixed. Thanks, Kip On Sat, Apr 3, 2010 at 9:20 AM, Alan Cox wrote: > Author: alc > Date: Sat Apr =A03 16:20:22 2010 > New Revision: 206140 > URL: http://svn.freebsd.org/changeset/base/206140 > > Log: > =A0Re-enable the call to pmap_release() by vmspace_dofree(). =A0The accou= nting > =A0problem that is described in the comment has been addressed. > > =A0Submitted by: kib > =A0Tested by: =A0 =A0pho (a few months ago) > =A0MFC after: =A0 =A06 weeks > > Modified: > =A0head/sys/vm/vm_map.c > > Modified: head/sys/vm/vm_map.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/vm/vm_map.c =A0 =A0 =A0 =A0Sat Apr =A03 15:52:32 2010 =A0 = =A0 =A0 =A0(r206139) > +++ head/sys/vm/vm_map.c =A0 =A0 =A0 =A0Sat Apr =A03 16:20:22 2010 =A0 = =A0 =A0 =A0(r206140) > @@ -313,6 +313,7 @@ vm_init2(void) > =A0static inline void > =A0vmspace_dofree(struct vmspace *vm) > =A0{ > + > =A0 =A0 =A0 =A0CTR1(KTR_VM, "vmspace_free: %p", vm); > > =A0 =A0 =A0 =A0/* > @@ -329,12 +330,8 @@ vmspace_dofree(struct vmspace *vm) > =A0 =A0 =A0 =A0(void)vm_map_remove(&vm->vm_map, vm->vm_map.min_offset, > =A0 =A0 =A0 =A0 =A0 =A0vm->vm_map.max_offset); > > - =A0 =A0 =A0 /* > - =A0 =A0 =A0 =A0* XXX Comment out the pmap_release call for now. The > - =A0 =A0 =A0 =A0* vmspace_zone is marked as UMA_ZONE_NOFREE, and bugs ca= use > - =A0 =A0 =A0 =A0* pmap.resident_count to be !=3D 0 on exit sometimes. > - =A0 =A0 =A0 =A0*/ > -/* =A0 =A0 pmap_release(vmspace_pmap(vm)); */ > + =A0 =A0 =A0 pmap_release(vmspace_pmap(vm)); > + =A0 =A0 =A0 vm->vm_map.pmap =3D NULL; > =A0 =A0 =A0 =A0uma_zfree(vmspace_zone, vm); > =A0} > >