From owner-cvs-src@FreeBSD.ORG Thu Mar 11 10:50:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D89F16A4DA; Thu, 11 Mar 2004 10:50:34 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F41E43D31; Thu, 11 Mar 2004 10:50:34 -0800 (PST) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i2BIoYGe094312; Thu, 11 Mar 2004 10:50:34 -0800 (PST) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i2BIoY15094309; Thu, 11 Mar 2004 10:50:34 -0800 (PST) (envelope-from phk) Message-Id: <200403111850.i2BIoY15094309@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 11 Mar 2004 10:50:34 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/specfs spec_vnops.c src/sys/kern vfs_bio.c src/sys/sys buf.h src/sys/ufs/ffs ffs_softdep.c src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2004 18:50:35 -0000 phk 2004/03/11 10:50:34 PST FreeBSD src repository Modified files: sys/fs/specfs spec_vnops.c sys/kern vfs_bio.c sys/sys buf.h sys/ufs/ffs ffs_softdep.c sys/ufs/ufs ufs_vnops.c Log: When I was a kid my work table was one cluttered mess an cleaning it up were a rather overwhelming task. I soon learned that if you don't know where you're going to store something, at least try to pile it next to something slightly related in the hope that a pattern emerges. Apply the same principle to the ffs/snapshot/softupdates code which have leaked into specfs: Add yet a buf-quasi-method and call it from the only two places I can see it can make a difference and implement the magic in ffs_softdep.c where it belongs. It's not pretty, but at least it's one less layer violated. Revision Changes Path 1.219 +0 -20 src/sys/fs/specfs/spec_vnops.c 1.431 +5 -3 src/sys/kern/vfs_bio.c 1.164 +10 -0 src/sys/sys/buf.h 1.152 +30 -0 src/sys/ufs/ffs/ffs_softdep.c 1.238 +2 -1 src/sys/ufs/ufs/ufs_vnops.c