From owner-svn-src-all@freebsd.org Mon Jan 22 18:57:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B482ED0108; Mon, 22 Jan 2018 18:57:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 14DEF68E15; Mon, 22 Jan 2018 18:57:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (astound-66-234-199-215.ca.astound.net [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 25E7F10A87D; Mon, 22 Jan 2018 13:57:37 -0500 (EST) From: John Baldwin To: Alexey Dokuchaev Cc: Jason Evans , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r319971 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src include lib/libc/stdlib/jemalloc Date: Mon, 22 Jan 2018 10:50:06 -0800 Message-ID: <1981273.UqQzroY0xG@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <20180122063210.GA43383@FreeBSD.org> References: <201706150715.v5F7F6aT031218@repo.freebsd.org> <20180118101031.GB21646@FreeBSD.org> <20180122063210.GA43383@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 22 Jan 2018 13:57:37 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 18:57:38 -0000 On Monday, January 22, 2018 06:32:10 AM Alexey Dokuchaev wrote: > On Thu, Jan 18, 2018 at 10:10:31AM +0000, Alexey Dokuchaev wrote: > > On Sat, Jan 13, 2018 at 05:04:30PM +0000, Alexey Dokuchaev wrote: > > > On Thu, Jun 15, 2017 at 07:15:06AM +0000, Jason Evans wrote: > > > > New Revision: 319971 > > > > URL: https://svnweb.freebsd.org/changeset/base/319971 > > > > > > > > Log: > > > > Update jemalloc to 5.0.0. > > > > > > I've finally bisected the problem of `games/quake2lnx' failing to start > > > (hanging) in GLX mode down to this commit. Reverting it and making "all > > > install" under `/usr/src/lib/libc' restores correct operation. > > > > > > If I run it as ``env LD_PRELOAD=/lib/libthr.so.3 quake2 ...'' it starts > > > normally. Do you have any ideas what might have broken it? Is this a > > > problem with how the Quake2 binary is linked, or with jemalloc? > > > > > > To reproduce: > > > > > > $ cd /usr/ports/games/quake2lnx && make all install > > > $ quake2 +set vid_ref glx > > > > Last two comments in https://github.com/jemalloc/jemalloc/issues/907 > > (October 10th-ish) could be related... > > I've just found out that similar bug was already reported back in July: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220767 > > ./danfe I wonder if it is tripping over pthread_once not working in libc. The stub for pthread_once in libc is a nop and has been for a long time. I added a functioning stub (called _libc_once) to libc for it's internal use (there is a _once() wrapper that will call _pthread_once when using libpthread and _libc_once otherwise). It might be interesting to build jemalloc with '-Dpthread_once=_once' to see if that makes a difference? -- John Baldwin