From owner-freebsd-current  Wed Nov 13  7:39:58 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3004D37B401
	for <current@FreeBSD.ORG>; Wed, 13 Nov 2002 07:39:57 -0800 (PST)
Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C633043E42
	for <current@FreeBSD.ORG>; Wed, 13 Nov 2002 07:39:56 -0800 (PST)
	(envelope-from mike@espresso.q9media.com)
Received: by espresso.q9media.com (Postfix, from userid 1002)
	id 38FE49BC3; Wed, 13 Nov 2002 10:31:11 -0500 (EST)
Date: Wed, 13 Nov 2002 10:31:11 -0500
From: Mike Barcroft <mike@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: Archie Cobbs <archie@dellroad.org>,
	Marc Recht <marc@informatik.uni-bremen.de>,
	Garrett Wollman <wollman@lcs.mit.edu>, current@FreeBSD.ORG
Subject: Re: addition to cdefs
Message-ID: <20021113103111.B98651@espresso.q9media.com>
References: <200211122349.gACNn5cX017668@arch20m.dellroad.org> <20021114010436.O5042-100000@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021114010436.O5042-100000@gamplex.bde.org>; from bde@zeta.org.au on Thu, Nov 14, 2002 at 01:13:13AM +1100
Organization: The FreeBSD Project
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Bruce Evans <bde@zeta.org.au> writes:
> Both have large namespace pollution (p and n are in the application
> namespace).  Both give huge code wih a copy of the function in every
> object file whose source file(s) include this header if inline functions
> are not actually inline (which happens if the compiler is gcc -O0 or
> non-gcc).

I fixed the namespace problems in the version I posted for review on
-standards.  Do you see any problems with changing FD_ZERO() to:

#define FD_ZERO(p)	do {				\
	fd_set *_p = (p);				\
	__size_t _n = _howmany(FD_SETSIZE, _NFDBITS);	\
	while (_n > 0)					\
		_p->__fds_bits[--_n] = 0;		\
} while (0);

...to overcome the issues with the inline version?

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message