From owner-svn-src-all@FreeBSD.ORG Tue Aug 12 03:18:06 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C13AC3A9; Tue, 12 Aug 2014 03:18:06 +0000 (UTC) Received: from mail107.syd.optusnet.com.au (mail107.syd.optusnet.com.au [211.29.132.53]) by mx1.freebsd.org (Postfix) with ESMTP id 82A562A97; Tue, 12 Aug 2014 03:18:06 +0000 (UTC) Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133]) by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id D13B5D409A4; Tue, 12 Aug 2014 13:17:56 +1000 (EST) Date: Tue, 12 Aug 2014 13:17:55 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: John Baldwin Subject: Re: svn commit: r269474 - in head: share/man/man4 sys/dev/vt In-Reply-To: <201408111315.16939.jhb@freebsd.org> Message-ID: <20140812121718.U1185@besplex.bde.org> References: <53de340e.52ce.7073778e@svn.freebsd.org> <20140805091730.N2827@besplex.bde.org> <201408111315.16939.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=fvDlOjIf c=1 sm=1 tr=0 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=9sZAoq1AbeMA:10 a=252g7Ztp5P0A:10 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=BvYZXN6Kv6LMIY-lhhQA:9 a=CjuIK1q_8ugA:10 Cc: svn-src-head@freebsd.org, Aleksandr Rybalko , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 03:18:06 -0000 On Mon, 11 Aug 2014, John Baldwin wrote: > On Monday, August 04, 2014 8:03:58 pm Bruce Evans wrote: >> On Mon, 4 Aug 2014, John Baldwin wrote: >>> I realize the API uses 'SPCL' as an abbreviation, but for user-facing things like a sysctl and tunable, I think it might be better to spell it out as > "specialkeys" instead? >> >> It is a bad name, and also gratuitously different from syscons where the >> names are: >> >> hw.syscons.kbd_reboot >> hw.syscons.kbd_debug >> hw.syscons.sc_no_suspend_vtswitch > > I would prefer individual nodes for vt along these lines as I think it is > clearer to the user ("what exactly constitutes a special key?") But rename them a bit so it is clearer that they give limited access control. The sysctl -d descriptions are no better about this: % hw.syscons.kbd_reboot: enable keyboard reboot % hw.syscons.kbd_debug: enable keyboard debug % hw.syscons.sc_no_suspend_vtswitch: Disable VT switch before suspend. These also have some style bugs ("enable" is not capitalized; the last description is terminated). The option name SC_DISABLE_KDBKEY is better. It more clearly controls a key, not debugging. The option name SC_DISABLE_REBOOT is no better. Bruce