From owner-freebsd-current Mon Feb 17 15: 3: 3 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A98737B401 for ; Mon, 17 Feb 2003 15:03:02 -0800 (PST) Received: from mail.evip.pl (mail.evip.com.pl [212.244.157.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BE3643F3F for ; Mon, 17 Feb 2003 15:03:01 -0800 (PST) (envelope-from w@evip.pl) Received: from w by mail.evip.pl with local (Exim 4.10) id 18kuHL-0002CZ-00 for current@freebsd.org; Tue, 18 Feb 2003 00:02:27 +0100 Date: Tue, 18 Feb 2003 00:02:27 +0100 From: Wiktor Niesiobedzki To: current@freebsd.org Subject: Re: IPFW/socheckuid() patch Message-ID: <20030217230227.GD2315@mail.evip.pl> References: <20030217224732.GC2315@mail.evip.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030217224732.GC2315@mail.evip.pl> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Feb 17, 2003 at 11:47:32PM +0100, Wiktor Niesiobedzki wrote: [...] There is an obvious mistake in patch (or change in ip_fw2.c should be considered). Cheers, Wiktor Niesiobedzki =================================================================== RCS file: sys/kern/uipc_socket.c,v retrieving revision 1.144 diff -u -r1.144 sys/kern/uipc_socket.c --- sys/kern/uipc_socket.c 2003/02/17 22:37:58 1.144 +++ sys/kern/uipc_socket.c 2003/02/17 22:56:41 @@ -1846,8 +1846,8 @@ { if (so == NULL) - return (EPERM); - if (so->so_cred->cr_uid == uid) return (0); - return (EPERM); + if (so->so_cred->cr_uid == uid) + return (1); + return (0); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message