Date: Wed, 21 Nov 2012 09:53:12 -0600 From: Bryan Drewery <bdrewery@freebsd.org> To: Eygene Ryabinkin <rea@freebsd.org> Cc: svn-ports-head@freebsd.org, Andrey Chernov <ache@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Erwin Lansing <erwin@freebsd.org>, Chris Rees <utisoft@gmail.com> Subject: Re: svn commit: r307612 - in head/misc/astrolog: . files Message-ID: <50ACF8E8.5080706@FreeBSD.org> In-Reply-To: <P1kYGGwXBWZ1fcuxwnoQYoZ6uu0@7TEDb4Yy37iQCK/hgFqwmvLmFqM> References: <201211210949.qAL9nl4a018306@svn.freebsd.org> <CADLo83-Yf0vt73kynPPJPCEcLex11g=SzJshbqmyr=bmHWaKUA@mail.gmail.com> <50ACB0A7.1030108@freebsd.org> <CADLo839jgAP_V3F4x%2BwSaFk65rLdvS-pPhaM7krP9FWHn5cFfA@mail.gmail.com> <50ACBE7D.70203@freebsd.org> <20121121120128.GC4474@droso.net> <P1kYGGwXBWZ1fcuxwnoQYoZ6uu0@7TEDb4Yy37iQCK/hgFqwmvLmFqM>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0DA31DA713E59D992E052D5F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/21/2012 8:53 AM, Eygene Ryabinkin wrote: > Wed, Nov 21, 2012 at 01:01:29PM +0100, Erwin Lansing wrote: >> On Wed, Nov 21, 2012 at 03:43:57PM +0400, Andrey Chernov wrote: >>> On 21.11.2012 15:10, Chris Rees wrote: >>> >>> Yes, but the new naming convention is something which should be decid= ed >>> by portmgr@ to keep all things in line. F.e. will it be '-' or '_' or= >>> '=3D' or some combination of them etc? It is unknown to me at this mo= ment, >>> so I prefer to stay the old one I see. >> >> "Please only use characters [-+._a-zA-Z0-9] for naming your patches. D= o >> not use any other characters besides them. Do not name your patches li= ke >> patch-aa or patch-ab etc, always mention the path and file name in pat= ch >> names." >> >> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow= -patch.html >> >> Imporovements to the handbook are of course always welcome. >=20 > The per-file patches are always make me sad: you're loosing the > metadata about the grouping of diff hunks into changes and makes the > non-trivial fixes harder to understand, so when I first took > maintainership of OpenOSPFD, I was struggling with the patch files, > because it was very non-trivial to find which patches should be > dropped for the new releases and which should be kept/modified and how > all hunks in all diffs are related to each other. And this makes life > for the new maintainers especially hard: they have no background on > what previous ones were patching and it is sometimes not really easy > to get the idea from the port commit logs, so some time should be > spent on resurrecting this metadata. >=20 > As I understand, the problem with the grouped patches is the order of > their application while the per-file patches has no such problem and > it is the only technical answer to the question "why handbook teaches > us about per-file patches rather than the real commit diffs", but if > we will implement the proper patch ordering (just by doing sort before > patch application), won't it go away? >=20 I agree. Splitting logically-grouped changes out into multiple patches is confusing, especially to future maintainers. IMHO this should not be a hard rule, but a suggestion if ordering is problematic. --=20 Regards, Bryan Drewery bdrewery@freenode/EFNet --------------enig0DA31DA713E59D992E052D5F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQrPjsAAoJEG54KsA8mwz5uoEP/i7mAZWRaANZY8F7LCskZKm5 iwSZsShGqKxKvImhw0Ti4IoHIZrauH0DzqtaSJSIGXnG3n6tnTsk/dfHpx3Mk1O4 fnaCOCFJfDv5YZikz1e3qJ8k6AvtpHAGZXVHe+cMKTM7ymKX+q/8/aNj9Tk5iAa5 /CojBBty1OyX37jXLD6RUxuStSPsswGwmLrBQG7Y1NiqZfnELsXNRt46/3eIGZ6E 8T9mHI9CifM+HBIv1w8aYAgW3IEIMXNg2r7vVQ56hsCR4QWMORN6Pkw3PNR3tIuS IuPiI1Ck4EdRUhf6CUC/7o29SO/jH62ZmO+Cu64m55Dh2vYt5nkTy+cEZ9o/QXDj MOwEG1/ukEy5dc2uGUqk9yz0dyNSXe9KCwIGBQXf1hnNYtS4Lfg0xRpF4nL1zKXU mRSPG2044OqqE2naOlh/KlBCK57386TmdATzL2ynJRUfN7pVJSdwIZoXUylNqd1J 5gZeZLXnbXPr+sIdQIh5RFn+rU8wf46Gx6V3J5xwCPwFK/gEgb0sgVoFR10hnxiM GEFMVSaPGB7OQhfyPQiLtNVlkNAI9faaQSPwn4iXDXFeiay+wKEJhX4QAnO5vibf Gz0u38cZ3CRrmh9ROw+w8IUVKy51KRQdfsD6fn3p9lp1tPtMwGLMtjnffS6qa/tQ N0P5P2lP3MePZvfc4wzI =fFg1 -----END PGP SIGNATURE----- --------------enig0DA31DA713E59D992E052D5F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50ACF8E8.5080706>