From nobody Tue Sep 5 07:40:13 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rfy8Y4ppkz4sdG0 for ; Tue, 5 Sep 2023 07:40:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rfy8Y2LD8z4SDW for ; Tue, 5 Sep 2023 07:40:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693899613; a=rsa-sha256; cv=none; b=pcuhjmJTE/p3jRmxoAHxSaOp+kq4ZHwK8yBt9K6OyL0NcweWgKIoLTZoXDuFCFmx3fbS4I l5R7KuaLHUGFz+OC1TlmSoDJcwRLjFgh7+y7h59GknmaLKLfy3c/YHbBTOTUEDL5XnFXQq LTxaoICz60cH7PllcZB1ty2JlXfoI06AJnDcaSnY92dLylj+2TCMd1LqJLJJJnJNUVeUkc VjVwCFcyRGjgF/vCsvBYNYxbQflf2DpEJc4o9fIc+zoFhB735GPMPBkW0bDGC08Tve4938 LtN9j56AypX4Z7SEzcypwmQ/+cZoT5o+Z5CWG3f32c3Mrw8rw/d9ulaqfTjEUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693899613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wnm27MZrKFZjuaKkOG+UNTC50zH3Q909zdemOGeHe5U=; b=Y7EmraxvYRkZGlvKeH8qC6/Gdkr1fgmq5XU1EJ2wQTejk+DYqXX1GHc4fLGQ0QHTULJl0S 4b65Dw0+ym2sxuxN5IHYiGDvs0DaVisBCy29KPRfASCZtU4A1zTR5mlLli8FsnNDd5+9hM DYboivZR7/UO+Bb3jvToyH0beuP/dVFoV2aw/VAfH0PZxaWzfbWhB4gSuevcYigns9kf6W P0w5JOT4VkgkSXQw81U72Jqf2IrZoOp0Yi0H7QftVQOvKcUUMLoWZQMLIFbqSvyHjlobMj 2Jz16v5Z9rpSnEJjvzgVHxJHqYEAS5se8ecVrWsx1VBPmX6Xs6Ri/vjBiN6q/g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rfy8Y1RQ7z9Tk for ; Tue, 5 Sep 2023 07:40:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3857eDVa017361 for ; Tue, 5 Sep 2023 07:40:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3857eD1M017360 for ports-bugs@FreeBSD.org; Tue, 5 Sep 2023 07:40:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 273495] [NEW PORT] devel/reposilite: repository manager for Maven based artifacts in JVM ecosystem Date: Tue, 05 Sep 2023 07:40:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: michael.osipov@siemens.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273495 --- Comment #6 from Michael Osipov --- A few issues: * Makefile: ** Should have: NO_ARCH=3D yes NO_BUILD=3D yes NO_TEST=3D yes ** Empty STRIP isn't necessary ** USE_RC_SUBR=3D${PORTNAME} ** REPOSILITEUSER?=3D${PORTNAME} ** I was once told that one should supply the DISTVERSION only and the framework will derive the PORTVERSION automatically * reposilite.in: ** reposilite_run_dir =3D> reposilite_rundir (similar to etcdir=3D ** reposilite_rundir: should be filtered from the Makefile ** reposilite_user: should be filtered from the Makefile ** reposilite_dir: does not make sense because the JAR cannot be moved, it = is mandated by the Makefile (convention) especially because you have hardcoded= the JAR name ** Beat me, but where does daemon(8) receive user/group to drop privs? ** Who needs this "export JAVA_HOME=3D${reposilite_java_home}"? ** reposilite_java_home is not used at all! reposilite_cmd completely ignor= es it. Totally defeats the purpose ** required_files: Does not make sense to me. Java presence is during build/installation; ${reposilite_config} is never created by you at installation time ** I believe that this is redundant: reposilite_precmd. All required trees should be created at installation time: See https://github.com/michael-o/freebsd-ports/blob/c44ab5af99444359c6baab54143= f2ddf8d21d999/devel/nexus2-oss/Makefile#L106-L108 and added to pkg-plist ** This is logically wrong: ${reposilite_dir:=3D"%%DATADIR%%"}. DATADIR is = in share for static (!) files installed and used read-only at runtime. It is n= ot a work directory. What you need is ${reposilite_workdir:=3D"%%WORKDIR%%"} whe= re WORKDIR points to /var/reposilite.=20 ** The header comment are partially inconsistent, e.g. rundir. ** folder =3D=3D> directory ** reposilite_flags or reposilite_args? Sould be args... ** reposilite_max_mem should be generalized to reposilite_java_opts. Why 32= M? Leave it empty since this should be user-configured unless you know better. ** reposilite_cmd: This should not be overwritable, no? Yes, I am picky, but the later you address the issues the more expensive it= is going to be. Please have a look at by Nexus 2 port, it separates between etcdir/rundir/workdir and datadir. Should be here as well: https://github.com/michael-o/freebsd-ports/tree/master/devel/nexus2-oss --=20 You are receiving this mail because: You are the assignee for the bug.=