From owner-freebsd-hackers@FreeBSD.ORG Tue Dec 3 18:02:11 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 66A85D6E for ; Tue, 3 Dec 2013 18:02:11 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 37235164D for ; Tue, 3 Dec 2013 18:02:10 +0000 (UTC) Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 98E6620BFE; Tue, 3 Dec 2013 13:02:09 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute4.internal (MEProxy); Tue, 03 Dec 2013 13:02:09 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:from:to:mime-version :content-transfer-encoding:content-type:subject:date:in-reply-to :references; s=smtpout; bh=cXVTERypdrffekHQBuVmpKVpaG0=; b=gaxS5 5bf5cJK1wu1uv/LTy3kA3qdrXZ+qI1Maz7xVVoX67+5nyKafFfFdEt2hCOkePmGE rL0NgButcnRBVUTOLWD02pDKtnphu0+UhoxJzSL2kWIjsDjuULp2AJ5/iBlqwg+R vSALE1zX2vbVoxdI6frWD1LUQ8RMYxeelQZsTw= Received: by web3.nyi.mail.srv.osa (Postfix, from userid 99) id 75600106EB5; Tue, 3 Dec 2013 13:02:09 -0500 (EST) Message-Id: <1386093729.5203.55046221.21CD5331@webmail.messagingengine.com> X-Sasl-Enc: 0y9mtIirnR2AtAIk92fbvWXtufHDsiqlFLZmVS9pYa1Q 1386093729 From: Mark Felder To: Stefan Wendler , freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-24db94df Subject: Re: Kind of hacky fix for banshee-2.6.0 Date: Tue, 03 Dec 2013 12:02:09 -0600 In-Reply-To: <3074012.QmsohyHcnK@hactar> References: <3074012.QmsohyHcnK@hactar> X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2013 18:02:11 -0000 On Mon, Dec 2, 2013, at 14:28, Stefan Wendler wrote: > Hi, > > I've noticed a long time ago that banshee was not compiling anymore. When > I > wrote the maintainer nobody replied. So I kind of dirty-hacky-fixed it > myself > today. > > I generally did the following: > > I the Makefile.in files of the sources I changed (where this variable was > available) > ASSEMBLY_BUILD_FLAGS = -unsafe > to > ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4 > > Then I compiled my way through the rest of the sources and found loads of > other files where this line was missing completely. I started by > including it > by hand but after the 20th Makefile.in it somehow got tedious. > > so I did a "export ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4" and then a make > install. Now it compiles and banshee works. > > I attached the patch fle that can be copied to multimedia/banshee/files > and > works-for-me (TM) > But I still have to do the export-thing before compiling. And I know this > is a > dirty hack. But I don't know if there is a way to include this once as a > global compile time variable. Or if I have to patch this into every > Makefile.in there is in banshee? > > Since I never did any patch at all for FreeBSD so far and didn't find > anything > about setting a global variable in the ports Makefile, I kind of hope > that > there is anybody out there who can guide me in the right direction? > Are all of these files Makefile.in or Makefile.am ? If so, this patch would fix it: Index: Makefile =================================================================== --- Makefile (revision 335567) +++ Makefile (working copy) @@ -126,4 +126,8 @@ PLIST_SUB+= OPT_WEBKITORYOUTUBE="@comment " .endif +post-patch: + ${FIND} ${WRKSRC} -name 'Makefile.*' | ${XARGS} ${REINPLACE_CMD} \ + -E 's|ASSEMBLY_BUILD_FLAGS = -unsafe|ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4|' + .include