From owner-svn-src-all@FreeBSD.ORG  Wed Oct 22 15:32:19 2008
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 244EC1065680;
	Wed, 22 Oct 2008 15:32:18 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Kostik Belousov <kostikbel@gmail.com>
Date: Wed, 22 Oct 2008 11:31:58 -0400
User-Agent: KMail/1.6.2
References: <200810221445.m9MEjUcq031169@svn.freebsd.org>
	<20081022150452.GD94031@deviant.kiev.zoral.com.ua>
In-Reply-To: <20081022150452.GD94031@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200810221132.02162.jkim@FreeBSD.org>
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, "Andrey A. Chernov" <ache@FreeBSD.org>
Subject: Re: svn commit: r184161 - head/sys/i386/i386
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2008 15:32:19 -0000

On Wednesday 22 October 2008 11:04 am, Kostik Belousov wrote:
> On Wed, Oct 22, 2008 at 02:45:30PM +0000, Andrey A. Chernov wrote:
> > Author: ache
> > Date: Wed Oct 22 14:45:30 2008
> > New Revision: 184161
> > URL: http://svn.freebsd.org/changeset/base/184161
> >
> > Log:
> >   Fix compiler error with missing/unneded ')'
> >
> > Modified:
> >   head/sys/i386/i386/identcpu.c
> >
> > Modified: head/sys/i386/i386/identcpu.c
> > =================================================================
> >============= --- head/sys/i386/i386/identcpu.c	Wed Oct 22
> > 10:12:21 2008	(r184160) +++ head/sys/i386/i386/identcpu.c	Wed Oct
> > 22 14:45:30 2008	(r184161) @@ -842,9 +842,9 @@ printcpuinfo(void)
> >  				cpu_feature &= ~CPUID_HTT;
> >
> >  			if (!tsc_is_invariant &&
> > -			    (strcmp(cpu_vendor, "AuthenticAMD") == 0 &&
> > -			    (amd_pminfo & AMDPM_TSC_INVARIANT) != 0 ||
> > -			    I386_CPU_FAMILY(cpu_id) >= 0x10))) {
> > +			    ((strcmp(cpu_vendor, "AuthenticAMD") == 0 &&
> > +			    (amd_pminfo & AMDPM_TSC_INVARIANT) != 0) ||
> > +			    I386_CPU_FAMILY(cpu_id) >= 0x10)) {
> >  				tsc_is_invariant = 1;
> >  				printf("\n  P-state invariant TSC");
> >  			}
>
> Taking apart commit message, I think you change is wrong
> semantically. Checking CPU_FAMILY without first checking vendor is
> meaningless.

Correct.  Please do not touch this part cause I am going to fix it and 
add more quirks.

Sorry for the breakage.

Jung-uk Kim