From owner-svn-src-all@FreeBSD.ORG  Tue Sep  8 17:14:15 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF4BC1065692;
	Tue,  8 Sep 2009 17:14:15 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 33DC78FC0A;
	Tue,  8 Sep 2009 17:14:15 +0000 (UTC)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 15C2669959;
	Tue,  8 Sep 2009 17:14:14 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.3/8.14.3) with ESMTP id n88HEPW3032054;
	Tue, 8 Sep 2009 17:14:25 GMT (envelope-from phk@critter.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 08 Sep 2009 17:58:50 +0200."
	<20090908155850.GM1577@garage.freebsd.pl> 
Date: Tue, 08 Sep 2009 17:14:25 +0000
Message-ID: <32053.1252430065@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r196976 - head/lib/libc/net 
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Sep 2009 17:14:15 -0000


>> @@ -33,6 +33,7 @@
>>  __FBSDID("$FreeBSD$");
>>  
>>  #include "namespace.h"
>> +#include <sys/param.h>
>>  #include <sys/types.h>
>
>style(9) seems to advice to include either types.h or param.h, but not both.

yeah, I had to dig deeper and found the _NO_NAMESPACE_POLLUTION hack
which makes a mess of <machine/param.h>.

I'm trying to do that stuff the right way, but it is cross-platform so
my universe needs to complete before commit.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.