From nobody Mon Jan 12 18:00:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqgBv6V1tz6Ntmb for ; Mon, 12 Jan 2026 18:00:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqgBv3tj8z3HRN for ; Mon, 12 Jan 2026 18:00:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768240807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8D3YyNl28/hHJQQVKB0HbB7TnN8wsyWOFmGC2P35FcM=; b=NiGvx+ZID5w+o9MbvivJGAZLsfWkNRE1iX64QMf98+UUapP2+0VAr00vwy1TJwvlID14H0 tbj+aBTlIMO/w0s2KoSKr0LtwhtvwCfQh3c6RaHbFPc+2EEv/jQ+SiHf2luB93yH0E9yt7 o+rbbkM29pJO+e9Y01Yk6hDexV/iJ3N7lTLP+UNpCiTA+Q8GegbO45Mw2iWYFgTQ6dTBqg ksK1nHiO2UXjjVSo0v3HMBwbg+KQ08LsDAJHXrPMEZdhW2z/lHFZOpY0orm0NnWbIziUh3 Gote9FvXjcWyUNFJDw94JHdxDWLY7z96khfdwjqjoXP/2izIEPFuI0w4uP7izQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768240807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8D3YyNl28/hHJQQVKB0HbB7TnN8wsyWOFmGC2P35FcM=; b=DVSQ+LhmJSkoprlQxM8DbpvMf4v0ktGoESDjGWxk0+nyTj+mqsmdjlj+PT9rj2Q5pDJ7Qu v8fCQ7BMCkd2XGS1d0kmR4LAprnGbamX2KqTc/cmqWijjYvRBXR3xhy6rGP0TR6sNuXVTJ MUis1CPhxuxcUdseZeKM8BVXzynsDwZI3Kb0LDvbwx12Oc2DBAO2BvfIa3xSFIMKqE8AB7 NG8cwgFk/ZINoCG8ndLV+F7b+ivlrJamncVlHh2fIwbDMLWGE+Od/N7ELxJ3wc7krNAdfR 1lDvNgU0miV8f1995AhhUmzmEVB50kGonch42oMCqkE2v/gNBfgE+CdnW7th2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768240807; a=rsa-sha256; cv=none; b=I/xOTYBNTpOpzPXZFluCuA5Aewj4QYp7QmgXoi3yu/z9qogRPwGBxYTvylhC0sbWE5DnwD FkxbSmb7+x12bHW++s3OHqmvXTWoZJmVmG+O1ZTpsDSim0TYeWTA3fTBGnwsh6oL7h4YhY bEK6l5FRk2aguCxjLaI3p6kUvio6aZrFNX1s2rBO1JzZ4lOBs2cIGhAm52HsGeFBiPT9ZW EBYnmkIEMCF1ldcSDdRho4Qsr6KABu+oXqEBu98Jual0iQuwlep4O4WMj2jtHkzrjaFM5p njX2u/x60DHnKmFvjPR29rkhQhEkBpZ6TST2BfavFFfX0WN1O8yOJAcPe+vqZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqgBv3M0kzctJ for ; Mon, 12 Jan 2026 18:00:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b3cd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 18:00:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: a7d9d1b19608 - stable/13 - zfs: emit .note.GNU-stack section for all ELF targets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a7d9d1b19608b5e1224e8b687aa2b91d714a71ed Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 18:00:07 +0000 Message-Id: <696536a7.3b3cd.7cea4b26@gitrepo.freebsd.org> The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=a7d9d1b19608b5e1224e8b687aa2b91d714a71ed commit a7d9d1b19608b5e1224e8b687aa2b91d714a71ed Author: Dimitry Andric AuthorDate: 2026-01-08 08:35:13 +0000 Commit: Dimitry Andric CommitDate: 2026-01-12 17:59:17 +0000 zfs: emit .note.GNU-stack section for all ELF targets On FreeBSD, linking the zfs kernel module with binutils ld 2.44 shows the following warning: ld: warning: aesni-gcm-avx2-vaes.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker Some of the `.S` files under `module/icp/asm-x86_64/modes` check whether to emit the `.note.GNU-stack` section using: #if defined(__linux__) && defined(__ELF__) We could add `&& defined(__FreeBSD__)` to the test, but since all other `.S` files in the OpenZFS tree use: #ifdef __ELF__ it would seem more logical to use that instead. Any recent ELF platform should support these note sections by now. Reviewed by: emaste, kib, imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D54578 (cherry picked from commit eb1b6ec7a79aff05f5f10e1d6b1c63a0d8dc5f2f) --- sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S | 2 +- sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S index cf17b3768712..9cdc2febf418 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S @@ -1264,7 +1264,7 @@ atomic_toggle_boolean_nv: .popsection /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif diff --git a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S index bf3724a23eae..57442e92155c 100644 --- a/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S +++ b/sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S @@ -717,7 +717,7 @@ gcm_ghash_avx: .popsection /* Mark the stack non-executable. */ -#if defined(__linux__) && defined(__ELF__) +#ifdef __ELF__ .section .note.GNU-stack,"",%progbits #endif