From owner-svn-src-head@freebsd.org Tue Jan 19 17:40:57 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2275BA87235; Tue, 19 Jan 2016 17:40:57 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 0EF3517B7; Tue, 19 Jan 2016 17:40:57 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 08C741452; Tue, 19 Jan 2016 17:40:57 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id B148815DE8; Tue, 19 Jan 2016 17:40:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id QJgNSD8e2pxP; Tue, 19 Jan 2016 17:40:54 +0000 (UTC) Subject: Re: svn commit: r291941 - in head: lib/libpam/modules/pam_ssh secure/lib/libssh secure/libexec/sftp-server secure/libexec/ssh-keysign secure/libexec/ssh-pkcs11-helper secure/usr.bin/scp secure/usr.bin/... DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 3BB2515DE2 References: <201512071608.tB7G89BZ095366@repo.freebsd.org> <86vb6phdug.fsf@desk.des.no> <569E60BA.6050007@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <569E7524.5040806@FreeBSD.org> Date: Tue, 19 Jan 2016 09:40:52 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <569E60BA.6050007@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n7OthJOQ3hMnnKTccDD1Q7dDMOM999R1w" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 17:40:57 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n7OthJOQ3hMnnKTccDD1Q7dDMOM999R1w Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/19/2016 8:13 AM, Bryan Drewery wrote: > On 1/19/2016 5:56 AM, Dag-Erling Sm=C3=B8rgrav wrote: >> Bryan Drewery writes: >>> Log: >>> Replace unneeded manual dependency on header by adding it to SRCS. >>> =20 >>> bsd.lib.mk and bsd.prog.mk already depend all objs on headers in SR= CS if >>> there is not yet a depend file. The headers in SRCS are never buil= t or >>> installed. After 'make depend' the header was already added as a p= roper >>> dependency on the objects where needed. >> >> This doesn't work. Try the following: >> >> $ cd /usr/src/secure/lib/libssh >> $ make depend && make >> $ touch /usr/src/crypto/openssh/ssh_namespace.h >> $ make >=20 > Well, it sort of works with WITH_FAST_DEPEND which will be default very= > shortly. >=20 =2E.. >> $ grep -c ssh_namespace $(make -V.OBJDIR)/.depend >> 0 >> >=20 > That is expected. The dependency is defined in bsd.lib.mk. Granted it i= s > dependent on .depend existing, but I am going to remove that check so i= t > is always defined. >=20 The problem with the old method (mkdep which is still default) is that the -include is not passed to mkdep. FAST_DEPEND does not have that issue since it generates the .depend files during compilation, where the -include is present. --=20 Regards, Bryan Drewery --n7OthJOQ3hMnnKTccDD1Q7dDMOM999R1w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWnnUkAAoJEDXXcbtuRpfPY/4H/RjLtky4QWRHAZRcjKHZeosg f5LvL1aouT5Tsz3TqHg8hcWFdJ+hy3WmbmNZ4RtWqw+fAYNDKEuIW0H8EZMBvQGJ xDztxvvcqArHXV0F55dJnmY3sTjUSVVT/qxISAp+3Jje3Wj9X5pKK6JgVlOGk/tH vrJ6HF+nNG4hWebbVtytbKoYyWDfMWM6VBUMiope65sr8bj4XQ8zHRSKT90eOd1E InLRAEwKTT6E/Tb1a9MtF/9zJHs7BQ7svi8cH7tXdfChecTcXaSfhqWN70uw9jJy nRFGT0G4WkvwRez/4/YZX491gVqqhjtSs0TnelBja4zR6wKzddax0kYgp8xFRRw= =Nvrk -----END PGP SIGNATURE----- --n7OthJOQ3hMnnKTccDD1Q7dDMOM999R1w--