From owner-freebsd-current@FreeBSD.ORG  Sun Jul 10 16:56:24 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 161E416A41C
	for <freebsd-current@freebsd.org>; Sun, 10 Jul 2005 16:56:24 +0000 (GMT)
	(envelope-from tataz@tataz.chchile.org)
Received: from postfix3-1.free.fr (postfix3-1.free.fr [213.228.0.44])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AC7E043D4C
	for <freebsd-current@freebsd.org>; Sun, 10 Jul 2005 16:56:23 +0000 (GMT)
	(envelope-from tataz@tataz.chchile.org)
Received: from tatooine.tataz.chchile.org
	(vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98])
	by postfix3-1.free.fr (Postfix) with ESMTP id B2798173496;
	Sun, 10 Jul 2005 18:56:22 +0200 (CEST)
Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000)
	id 4CCC5405B; Sun, 10 Jul 2005 18:56:22 +0200 (CEST)
Date: Sun, 10 Jul 2005 18:56:22 +0200
From: Jeremie Le Hen <jeremie@le-hen.org>
To: Artem Ignatiev <zazubrik@mail.ru>
Message-ID: <20050710165622.GW39292@obiwan.tataz.chchile.org>
References: <20041102222000.GA65845@xor.obsecurity.org>
	<20050706073205.GA942@galgenberg.net>
	<20050706085737.GT73907@obiwan.tataz.chchile.org>
	<200507061116.17267.thierry@herbelot.com>
	<20050708215620.GN39292@obiwan.tataz.chchile.org>
	<7FCC20EB-A240-4EDC-B09A-31BEE5129676@mail.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7FCC20EB-A240-4EDC-B09A-31BEE5129676@mail.ru>
User-Agent: Mutt/1.5.9i
Cc: freebsd-current@freebsd.org
Subject: Re: HEADS UP: Ports are not ready for CFLAGS=-O2 in 6.0
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jul 2005 16:56:24 -0000

Hi Artem,

> >If we add something like this in ports/Mk/bsd.port.mk :
> >%%%
> >    .if defined(PORT_CFLAGS)
> >    CFLAGS=${PORT_CFLAGS}
> >    .end
> >%%%
> >
> >This will obviously break POLA because setting CFLAGS won't work as
> >expected.
> 
> Why not :
> .if defined(PORT_CFLAGS) && !defined(CFLAGS)
> CFLAGS=${PORT_CFLAGS}
> .endif

For me, the goal of PORT_CFLAGS is to bring the possibility to specify
_alternate_ CFLAGs when building port.  This means that PORT_CFLAGS
needs to be usable even if CFLAGS is specified.  Typically, make.conf(5)
would contain both variables.

> or even:
> .if defined(PORT_CFLAGS)
> CFLAGS=${PORT_CFLAGS} ${CFLAGS}
> .endif

The problem is mostly the same here.  If make.conf(5) contains :
%%%
	CFLAGS="-O2 -pipe -fomit-frame-pointer"
	PORT_CFLAGS="-O -pipe"
%%%

what you have written above would lead to have CFLAGS containing :
%%%
	-O -pipe -O2 -pipe -fomit-frame-pointer
%%%


However, I'm maybe misunderstanding what you said.  In this case,
correct me please.

Best regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >