From owner-freebsd-bugs@freebsd.org Tue Aug 6 05:29:20 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30CDDB7DCC for ; Tue, 6 Aug 2019 05:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 462jqh0b45z4f00 for ; Tue, 6 Aug 2019 05:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 14049B7DCB; Tue, 6 Aug 2019 05:29:20 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13CA8B7DC9 for ; Tue, 6 Aug 2019 05:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 462jqg6pT2z4dyy for ; Tue, 6 Aug 2019 05:29:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E086227360 for ; Tue, 6 Aug 2019 05:29:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x765TJd4048065 for ; Tue, 6 Aug 2019 05:29:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x765TJ5C048064 for bugs@FreeBSD.org; Tue, 6 Aug 2019 05:29:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 239669] fails to build valgrind Date: Tue, 06 Aug 2019 05:29:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: naito.yuichiro@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Aug 2019 05:29:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239669 Bug ID: 239669 Summary: fails to build valgrind Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: naito.yuichiro@gmail.com Since r348628, FreeBSD head fails to build devel/valgrind as follows. I believe this is not a port problem. ``` cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I../VEX/pub -I../VEX/pub -DVGA_x 86=3D1 -DVGO_freebsd=3D1 -DVGP_x86_freebsd=3D1 -DVGPV_x86_freebsd_vanilla= =3D1 -I../coreg rind -DVG_LIBDIR=3D"\"/usr/local/lib/valgrind"\" -DVG_PLATFORM=3D"\"x86-fre= ebsd\"" -B/usr/lib32 -m32 -O2 -g -Wall -Wmissing-prototypes -Wshadow -Wpointer-arith -Ws trict-prototypes -Wmissing-declarations -Wno-format-zero-length -Wno-tautologica l-compare -fno-strict-aliasing -fno-builtin -fomit-frame-pointer=20 -Wno-long-long -O2 -pipe -march=3Dskylake -fstack-protector-strong -fno-strict-aliasing= =20 -Wno-t autological-compare -Wno-cast-align -Wno-self-assign -fno-stack-protector -= MT m_ debuginfo/libcoregrind_x86_freebsd_a-readelf.o -MD -MP -MF m_debuginfo/.deps/lib coregrind_x86_freebsd_a-readelf.Tpo -c -o m_debuginfo/libcoregrind_x86_freebsd_a -readelf.o `test -f 'm_debuginfo/readelf.c' || echo './'`m_debuginfo/readel= f.c In file included from m_debuginfo/readelf.c:35: In file included from ./pub_core_vki.h:44: In file included from ../include/pub_tool_vki.h:54: ../include/vki/vki-freebsd.h:1958:1: warning: typedef requires a name [-Wmissing-declarations] typedef struct vki_i386_get_xfpustate { ^~~~~~~ ../include/vki/vki-freebsd.h:1963:1: warning: typedef requires a name [-Wmissing-declarations] typedef struct vki_amd64_get_xfpustate { ^~~~~~~ m_debuginfo/readelf.c:1094:54: error: use of undeclared identifier 'ELF_NOTE_GNU' if (ML_(img_strcmp_c)(img, name_ioff, ELF_NOTE_GNU) =3D=3D 0 ^ m_debuginfo/readelf.c:1134:54: error: use of undeclared identifier 'ELF_NOTE_GNU' if (ML_(img_strcmp_c)(img, name_ioff, ELF_NOTE_GNU) =3D=3D 0 ^ ``` r348628 commit added ``` #define NT_GNU_BUILD_ID 3 ``` in sys/elf_common.h. In m_debuginfo/readelf.c of valgrind source, ``` # ifdef NT_GNU_BUILD_ID if (is_elf_object_file_by_DiImage(img, rel_ok)) { (snip) if (ML_(img_strcmp_c)(img, name_ioff, ELF_NOTE_GNU) =3D=3D 0 && note.n_type =3D=3D NT_GNU_BUILD_ID) { ``` ELF_NOTE_GNU is referenced if NT_GNU_BUILD_ID is defined, but it is not defined in sys/elf_common.h. I've tried to add ``` #define ELF_NOTE_GNU "GNU" ``` in sys/elf_common.h. It works for me. Please consider to add the definition. --=20 You are receiving this mail because: You are the assignee for the bug.=