From owner-cvs-all Wed Jul 4 1:56: 1 2001 Delivered-To: cvs-all@freebsd.org Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by hub.freebsd.org (Postfix) with ESMTP id A3E7337B405; Wed, 4 Jul 2001 01:55:53 -0700 (PDT) (envelope-from mjacob@feral.com) Received: from beppo (mjacob@beppo [192.67.166.79]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id f648tnS09938; Wed, 4 Jul 2001 01:55:49 -0700 (PDT) (envelope-from mjacob@feral.com) Date: Wed, 4 Jul 2001 01:55:49 -0700 (PDT) From: Matthew Jacob X-Sender: mjacob@beppo Reply-To: mjacob@feral.com To: Bruce Evans Cc: Greg Lehey , Lars Fredriksen , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_sa.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 4 Jul 2001, Bruce Evans wrote: > On Mon, 2 Jul 2001, Greg Lehey wrote: > > > On Monday, 2 July 2001 at 9:39:18 -0700, Lars Fredriksen wrote: > > > lars 2001/07/02 09:39:18 PDT > > > > > > Modified files: > > > sys/cam/scsi scsi_sa.c > > > Log: > > > Reviewed by: Matthew Jacob > > > Changed the timeout to wait for writing of filemarks to complete from 1 > > > minute to 3 minutes. This should probably be enhanced to be a sysctl variable. > > > > Shouldn't this be a function of the tape drive? > > Of course. sysctl() is not very suitable for controlling devices. The amount of time to wait for an operation to complete is a function of a specific device (and type of media too). The means of controlling that specific device's timeout may either be achieved with existing ioctl mechanism (expanded mtio, e.g.), sysctl (as has been suggested), or some other mechanism (new ioctl, other). There already are a lot of other device 'quirks' that need to be passed to the device driver. The current practice of compiling device quirks is absurd. I have old mail from Mike Smith (about two years old now) about how to start using the hint mechanism for this. This is probably where the device timeout should go. However, sysctl is a good choice for dynamically tunable ad hoc variables- e.g. 'number of retries' for scsi_da. -matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message