From owner-freebsd-current Sun Aug 23 23:53:30 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA03864 for freebsd-current-outgoing; Sun, 23 Aug 1998 23:53:30 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from gjp.erols.com (alex-va-n008c079.moon.jic.com [206.156.18.89]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA03856 for ; Sun, 23 Aug 1998 23:53:26 -0700 (PDT) (envelope-from gjp@gjp.erols.com) Received: from gjp.erols.com (gjp@localhost.erols.com [127.0.0.1]) by gjp.erols.com (8.8.8/8.8.7) with ESMTP id CAA14173; Mon, 24 Aug 1998 02:52:22 -0400 (EDT) (envelope-from gjp@gjp.erols.com) X-Mailer: exmh version 2.0.1 12/23/97 To: Bill Paul cc: chuckr@glue.umd.edu (Chuck Robey), current@FreeBSD.ORG From: "Gary Palmer" Subject: Re: pciconf In-reply-to: Your message of "Sun, 23 Aug 1998 21:47:58 EDT." <199808240147.VAA19462@skynet.ctr.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 24 Aug 1998 02:52:21 -0400 Message-ID: <14169.903941541@gjp.erols.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bill Paul wrote in message ID <199808240147.VAA19462@skynet.ctr.columbia.edu>: > I don't know why the code is turned off. It looks as though the > other cases should work though. To quote the code: case PCIOCGETCONF: #ifdef NOTYET static struct pci_conf *pci_dev_list; static unsigned pci_dev_list_count; static unsigned pci_dev_list_size; cio = (struct pci_conf_io *)data; iolen = min(cio->pci_len, pci_dev_list_count * sizeof(struct pci_conf)); cio->pci_len = pci_dev_list_count * sizeof(struct pci_conf); error = copyout(pci_dev_list, cio->pci_buf, iolen); Spot that (even if you move the variable decls to the proper location), that pci_dev_list_count and pci_dev_list_size are never calculated. My guess is that there is meant to be code elsewhere to initialize those, but its not written yet. Gary -- Gary Palmer FreeBSD Core Team Member FreeBSD: Turning PC's into workstations. See http://www.FreeBSD.ORG/ for info To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message