From owner-freebsd-current@FreeBSD.ORG  Thu Dec 15 08:56:52 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 761181065670;
	Thu, 15 Dec 2011 08:56:52 +0000 (UTC)
	(envelope-from fjoe@samodelkin.net)
Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com
	[209.85.161.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 0FC868FC08;
	Thu, 15 Dec 2011 08:56:51 +0000 (UTC)
Received: by ggnp1 with SMTP id p1so2463560ggn.13
	for <multiple recipients>; Thu, 15 Dec 2011 00:56:51 -0800 (PST)
MIME-Version: 1.0
Received: by 10.182.45.6 with SMTP id i6mr1144207obm.3.1323939411351; Thu, 15
	Dec 2011 00:56:51 -0800 (PST)
Received: by 10.182.76.225 with HTTP; Thu, 15 Dec 2011 00:56:51 -0800 (PST)
X-Originating-IP: [93.92.220.178]
In-Reply-To: <CAGH67wSYSTkxZp-Cf6NiPJESF0ry_ddhfPs3rPMo27J9dzRVuw@mail.gmail.com>
References: <201111291607.26546.jhb@freebsd.org>
	<A6C0CFB3-A657-41AA-8A2E-172D95BD0F98@bsdimp.com>
	<20111201002515.GA50028@freebsd.org>
	<CAGH67wQFecLHFsANmWFSr6e+99P1QY9erNzoXFmJG40RntFazQ@mail.gmail.com>
	<20111201014349.GA61475@freebsd.org>
	<CAGH67wT18DLu+OhOOw-Pjyq9az0pWD39y4nuDY-nDyPOKbmd8Q@mail.gmail.com>
	<CAGH67wQGnSfnO0H4ok2=czm7uxdwY+BuDmtQdwuswjSBGt8szw@mail.gmail.com>
	<CADe0-4niyiLyTSofbnpovb4B-WpjnC9VEEM3_GeZFi-xVws=LQ@mail.gmail.com>
	<CAGH67wSYSTkxZp-Cf6NiPJESF0ry_ddhfPs3rPMo27J9dzRVuw@mail.gmail.com>
Date: Thu, 15 Dec 2011 15:56:51 +0700
Message-ID: <CADe0-4n_LzKy+Gr=1ZtxBuqwAditkeQEsNzVgVdhz526MCxc_w@mail.gmail.com>
From: Max Khon <fjoe@samodelkin.net>
To: Garrett Cooper <yanegomi@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: Alexander Best <arundel@freebsd.org>, Doug Barton <dougb@freebsd.org>,
	current@freebsd.org, Warner Losh <imp@bsdimp.com>
Subject: Re: Remove debug echo
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2011 08:56:52 -0000

Garrett,

On Thu, Dec 15, 2011 at 10:39 AM, Garrett Cooper <yanegomi@gmail.com> wrote:

>> If someone would please, PLEASE commit this.. I will give you beer, or
> >> wine, or a copy of Skyrim, or a few months subscription to WoW, or
> >> something else of value to you that we could negotiate :)... I'm quite
> >> frankly tired of having to playing guessing games fishing through logs
> >> trying to determine build errors on FreeBSD if and when they do occur
> >> with pmake, and I'm sure that a number of developers and build/release
> >> engineers out there are in the same boat as I am.
> >
> >
> > Can you explain why did you remove MESSAGE() invocations in your patch?
> > Other than that the patch looks good to me.
>
>     I thought that printing out MESSAGE and the more informative
> *printf was kind of redundant.
> Thanks!
> -Garrett
>
> PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make
> would segfault as MESSAGE depends on targFmt and targPrefix being set
> to something sane (they both default to NULL -- one explicitly, the
> other implicitly because it's in the .BSS). These vars are only set in
> one section of code, but I took the easy route out to avoid
> accidentally breaking other code paths and because what I did in the
> previously attached patch was simple to implement and test.
>

I did not mean that you should use MESSAGE() for your purposes, but
removing existing "invocations" seems to be unnecessary.

Max