From owner-freebsd-audit Thu Jun 20 15:25:13 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mailb.telia.com (mailb.telia.com [194.22.194.6]) by hub.freebsd.org (Postfix) with ESMTP id A896337B40E; Thu, 20 Jun 2002 15:25:00 -0700 (PDT) Received: from d1o1075.telia.com (d1o1075.telia.com [213.67.243.241]) by mailb.telia.com (8.11.6/8.11.6) with ESMTP id g5KMOxg21270; Fri, 21 Jun 2002 00:24:59 +0200 (CEST) Received: from ludd.luth.se (h183n1fls22o1075.telia.com [217.209.40.183]) by d1o1075.telia.com (8.10.2/8.10.1) with ESMTP id g5KMOws14919; Fri, 21 Jun 2002 00:24:58 +0200 (CEST) Message-ID: <3D125661.9040704@ludd.luth.se> Date: Fri, 21 Jun 2002 00:25:37 +0200 From: =?ISO-8859-1?Q?Joachim_Str=F6mbergson?= Organization: =?ISO-8859-1?Q?Str=F6mbergson_Intergalactic_AB?= User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.0.0) Gecko/20020607 X-Accept-Language: en-US MIME-Version: 1.0 To: Mike Barcroft Cc: Giorgos Keramidas , audit@FreeBSD.ORG Subject: Minor change to rusers (Was: Re: minor header change in src/bin/dd/misc.c) References: <20020609014512.GA72307@hades.hell.gr> <20020608220030.D87326@espresso.q9media.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Aloha! Mike Barcroft wrote: > Giorgos Keramidas writes: > >>The source of bin/dd/misc.c doesn't use any of the functions of >> but uses strlen, which is defined in . The >>following seems to fix the only warning this file triggers for me. >>Does it seem ok to you all? > > > Yes, it's correct. is almost always wrong for BSD code. > I removed the include of from when I cleaned up > those headers for POSIX compatibility, so there are probably other > mis-includes throughout the system. It seems that this applies to /usr/bin/rusers too. AFAIK the compilation goes through and the behaviour seems to be unaltered. How about this patch? --- rusers.c Wed Jul 4 22:20:31 2001 +++ rusers.c Fri Jun 21 00:18:02 2002 @@ -46,7 +46,7 @@ #include #include #include -#include +#include #include #define MAX_INT 0x7fffffff -- Med vänlig hälsning, Cheers! Joachim Strömbergson ============================================================================ Joachim Strömbergson - ASIC designer, nice to *cute* animals. snail: phone: mail & web: Sävenäsgatan 5A +46 31 - 27 98 47 watchman@ludd.luth.se 416 72 Göteborg +46 733 75 97 02 www.ludd.luth.se/~watchman ============================================================================ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message