From owner-freebsd-ports@FreeBSD.ORG Sat Jul 26 21:41:11 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3C811065672 for ; Sat, 26 Jul 2008 21:41:10 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E62AD8FC0C; Sat, 26 Jul 2008 21:41:09 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <488B99F7.80602@FreeBSD.org> Date: Sat, 26 Jul 2008 23:41:11 +0200 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: Dirk Meyer References: <08GlBzRclM@dmeyer.dinoex.sub.org> <08GlBzRclM@dmeyer.dinoex.sub.org> <4889A1B8.9060900@FreeBSD.org> <488B15E1.1090802@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ports@freebsd.org Subject: Re: Mk/bsd.openssl.mk optimization X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2008 21:41:11 -0000 Dirk Meyer wrote: > Kris Kennaway schrieb:, > >>> openssl does set NOPRECIOUSMAKEVARS=yes, >>> so that part ist skipped in bsd.port.subdir.mk. >> OK, but why is this necessary? > > otherwise the build breaks, > as the length of the commandline reaches a limit. We're not talking about builds, but other processing of the bsd.openssl.mk such as for 'make describe'. I don't see why NOPRECIOUSMAKEVARS should be relevant for that since it's not invoking further child makes. To repeat, why can't you set the openssl variables in bsd.port.subdir.mk and pass them in to the port-level make process instead of recomputing them with every port? Kris P.S. I am not sure that same limit still exists in supported versions anyway